Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] contract_variable_qty_timesheet: Migration to 16.0 #1110

Merged

Conversation

danypr92
Copy link
Contributor

@danypr92 danypr92 commented Aug 7, 2024

This PR migrates the contract_variable_qty_timesheet module from Odoo version 15.0 to version 16.0.

@danypr92 danypr92 mentioned this pull request Aug 7, 2024
13 tasks
@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

@danypr92 danypr92 force-pushed the 16.0-mig-contract_variable_qty_timesheet branch from 1877981 to 0d2c797 Compare August 7, 2024 07:58
carlosdauden and others added 10 commits August 7, 2024 10:04
Currently translated at 66.7% (2 of 3 strings)

Translation: contract-11.0/contract-11.0-contract_variable_qty_timesheet
Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract_variable_qty_timesheet/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: contract-11.0/contract-11.0-contract_variable_qty_timesheet
Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract_variable_qty_timesheet/de/
* Standard procedure
* README by fragments
* Promoted to Production/Stable and declared maintainers
* Code adapted to v12
* Tests added
Currently translated at 66.7% (2 of 3 strings)

Translation: contract-12.0/contract-12.0-contract_variable_qty_timesheet
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_variable_qty_timesheet/pt_BR/
@danypr92 danypr92 force-pushed the 16.0-mig-contract_variable_qty_timesheet branch from 0d2c797 to 9df6690 Compare August 7, 2024 08:09
@danypr92
Copy link
Contributor Author

danypr92 commented Aug 7, 2024

@pedrobaeza Done!

Thanks for the comment. I've followed the guide, and since it's only a one major version upgrade, I believe I've completed all the necessary tasks.

I realize that I haven't implemented the distribution to separate the timesheet entries in the analytic account based on the selected percentages. However, we need this simpler version first, and then we can discuss the distribution. Is that okay with you?

@pedrobaeza
Copy link
Member

Ok about the procedure. Now reviewers should say the rest.

@danypr92
Copy link
Contributor Author

danypr92 commented Aug 7, 2024

Ping @carlosdauden @carolinafernandez-tecnativa please, can you review the proposal?

@pedrobaeza
Copy link
Member

We (Tecnativa) are migrating this module to v17, so please review that one, and if similar/equal, then both PRs can be merged together.

@pedrobaeza
Copy link
Member

/ocabot migration contract_variable_qty_timesheet

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 7, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM, could you please squash administrative commits and take a look of comment before?

Thanks.

contract_variable_qty_timesheet/readme/USAGE.rst Outdated Show resolved Hide resolved
[UPD] Update contract_variable_qty_timesheet.pot
[BOT] post-merge updates
Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-15.0/contract-15.0-contract_variable_qty_timesheet
Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract_variable_qty_timesheet/
@danypr92 danypr92 force-pushed the 16.0-mig-contract_variable_qty_timesheet branch from 9df6690 to 4f4c465 Compare August 7, 2024 17:25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks :)

@pedrobaeza
Copy link
Member

@danypr92 please review #1104

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1110-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7873c83 into OCA:16.0 Aug 17, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cad71bc. Thanks a lot for contributing to OCA. ❤️

@adriapalleja adriapalleja deleted the 16.0-mig-contract_variable_qty_timesheet branch August 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.