-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] contract_variable_qty_timesheet: Migration to 16.0 #1110
[16.0][MIG] contract_variable_qty_timesheet: Migration to 16.0 #1110
Conversation
Thanks for the contribution. Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0. If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance. |
1877981
to
0d2c797
Compare
Currently translated at 66.7% (2 of 3 strings) Translation: contract-11.0/contract-11.0-contract_variable_qty_timesheet Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract_variable_qty_timesheet/it/
Currently translated at 100.0% (3 of 3 strings) Translation: contract-11.0/contract-11.0-contract_variable_qty_timesheet Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract_variable_qty_timesheet/de/
* Standard procedure * README by fragments * Promoted to Production/Stable and declared maintainers * Code adapted to v12 * Tests added
Currently translated at 66.7% (2 of 3 strings) Translation: contract-12.0/contract-12.0-contract_variable_qty_timesheet Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_variable_qty_timesheet/pt_BR/
0d2c797
to
9df6690
Compare
@pedrobaeza Done! Thanks for the comment. I've followed the guide, and since it's only a one major version upgrade, I believe I've completed all the necessary tasks. I realize that I haven't implemented the distribution to separate the timesheet entries in the analytic account based on the selected percentages. However, we need this simpler version first, and then we can discuss the distribution. Is that okay with you? |
Ok about the procedure. Now reviewers should say the rest. |
Ping @carlosdauden @carolinafernandez-tecnativa please, can you review the proposal? |
We (Tecnativa) are migrating this module to v17, so please review that one, and if similar/equal, then both PRs can be merged together. |
/ocabot migration contract_variable_qty_timesheet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review LGTM, could you please squash administrative commits and take a look of comment before?
Thanks.
[UPD] Update contract_variable_qty_timesheet.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-15.0/contract-15.0-contract_variable_qty_timesheet Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract_variable_qty_timesheet/
9df6690
to
4f4c465
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks :)
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at cad71bc. Thanks a lot for contributing to OCA. ❤️ |
This PR migrates the contract_variable_qty_timesheet module from Odoo version 15.0 to version 16.0.