[17.0][MIG] contract_variable_quantity: Migration to version 17.0 #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
================================================= Variable quantity in contract recurrent invoicing ================================================= With this module, you will be able to define in recurring contracts some lines with variable quantity according a provided formula. Configuration ============= * Go to Sales > Configuration > Contracts > Formulas (quantity). * Define any formula based on Python code that stores at some moment a float/integer value of the quantity to invoice in the variable 'result'. You can use these variables to compute your formula: * *env*: Environment variable for getting other models. * *context*: Current context dictionary. * *user*: Current user. * *line*: Contract recurring invoice line that triggers this formula. * *contract*: Contract whose line belongs to. * *invoice*: Invoice (header) being created. Usage ===== To use this module, you need to: * Go to Sales -> Contracts and select or create a new contract. * Check *Generate recurring invoices automatically*. * Add a new recurring invoicing line. * Select "Variable quantity" in column "Qty. type". * Select one of the possible formulas to use (previously created).
* Bump version * Change openerp references to odoo * Installable to True * Change permissions & views to accounting dependency
Add template functionality for contracts
* [IMP] Add variable qty to contract template view * Bump minor version
If you have contract lines with automatic price and your pricelist contains different prices per quantity, the price is not changed when computing quantity. This PR fixes this.
Bug description --------------- `account.analytic.contract.line` inherits `account.analytic.invoice.line` `account.analytic.invoice.line` defines field `analytic_account_id`: - comodel='account.analytic.account' `account.analytic.contract.line` redefines field `analytic_account_id`: - comodel='account.analytic.contract' On attempt to extend `account.analytic.invoice.line` model adding field that depends on `analytic_account_id.date_start` Odoo fails to update, because it adds this field to `account.analytic.contract.line` through inheritance, and `account.analytic.contract` model have no this field. What is done ------------ Change inheritance order: - `account.analytic.invoice.line` inherits `account.analytic.contract.line` - no file renames at this stage (this wil be done in next commit)
- contract - contract_variable_quantity
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-contract_variable_quantity
branch
from
a377e18 to
02887a0
Compare
|
ping @pedrobaeza |
There was a problem hiding this comment.
1- Please squash administrative commits.
2- When creating a new customer contract i got this error message
Please check this contract configuration that is not working
Attributes invisible,required are not well defined so im not able for example as introducing qty formula
Thanks
| @@ -0,0 +1,8 @@ | |||
| To use this module, you need to: | |||
|
|
|||
| 1. Go to Invoicing \> Sales \> Contracts and select or create a new | |||
There was a problem hiding this comment.
This should be: Go to Invoicing > Customers > Customers Contracts
Currently translated at 100.0% (35 of 35 strings) Translation: contract-16.0/contract-16.0-contract_variable_quantity Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_variable_quantity/it/
Currently translated at 68.5% (24 of 35 strings) Translation: contract-16.0/contract-16.0-contract_variable_quantity Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_variable_quantity/hr/
Currently translated at 100.0% (35 of 35 strings) Translation: contract-16.0/contract-16.0-contract_variable_quantity Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_variable_quantity/sv/
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-contract_variable_quantity
branch
from
02887a0 to
233b77a
Compare
| </h1> | ||
| </div> | ||
| <group string="Code"> | ||
| <div style="margin-top: 4px;"> |
There was a problem hiding this comment.
This is displaying weird, please review it, something must be changed, review with others module version
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-contract_variable_quantity
branch
from
233b77a to
42457f5
Compare
|
All changes have been made. |
|
/ocabot migration contract_variable_quantity |
pedrobaeza
approved these changes
Aug 19, 2024
carolinafernandez-tecnativa
approved these changes
Aug 19, 2024
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 5a66776. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT50113