Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] contract: report translations & change structure #1078

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Apr 23, 2024

Description of the problem:
Go to Invoicing -> Customer Contracts and try to print a contract.
Normally when you print a contract the default language of that one bases on customer language but not works in that report.
Example:
Your default language is Spanish and your customer's default language is English
Try to print the report and you see that the report prints in Spanish and not in English.
I changed the structure because i'm base of the report of an invoice from the odoo's core structure(see more in the links below):

https://github.com/odoo/odoo/blob/16.0/addons/account/views/report_invoice.xml#L329
https://github.com/odoo/odoo/blob/16.0/addons/account/views/report_invoice.xml#L4

I test that structure first and works perfect and I try to reproduce in that case and works fine.

contract_report_failed.webm
contract_report_works.webm

@peluko00
Copy link
Contributor Author

Fixed Module report

cc https://github.com/APSL 154355

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated functionality in Runboat

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 25, 2024
@peluko00 peluko00 force-pushed the 16.0-fix-contract-report_structure branch from 3486de5 to 835f145 Compare August 26, 2024 05:23
@peluko00
Copy link
Contributor Author

Any update @pedrobaeza for this fix?

Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 26, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1078-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f4d3731 into OCA:16.0 Aug 26, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aa4996b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants