-
-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] contract: report translations & change structure #1078
Conversation
Fixed Module report cc https://github.com/APSL 154355 @miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated functionality in Runboat
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
3486de5
to
835f145
Compare
Any update @pedrobaeza for this fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge minor
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at aa4996b. Thanks a lot for contributing to OCA. ❤️ |
Description of the problem:
Go to Invoicing -> Customer Contracts and try to print a contract.
Normally when you print a contract the default language of that one bases on customer language but not works in that report.
Example:
Your default language is Spanish and your customer's default language is English
Try to print the report and you see that the report prints in Spanish and not in English.
I changed the structure because i'm base of the report of an invoice from the odoo's core structure(see more in the links below):
https://github.com/odoo/odoo/blob/16.0/addons/account/views/report_invoice.xml#L329
https://github.com/odoo/odoo/blob/16.0/addons/account/views/report_invoice.xml#L4
I test that structure first and works perfect and I try to reproduce in that case and works fine.
contract_report_failed.webm
contract_report_works.webm