Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] Module contract_invoice_auto_post: to 16.0 #1013

Conversation

manuelcalerosolis
Copy link

This module gets the value of the auto post variable in client contract and it automatically transfers the value of the variable to the invoice. Moreover, it will check periodically the status of this value and will confirm the invoice when it is programed to happen.

@manuelcalerosolis manuelcalerosolis force-pushed the 16.0-new-contract_invoice_auto_post branch 4 times, most recently from e9af554 to c305256 Compare October 26, 2023 22:58
@manuelcalerosolis manuelcalerosolis force-pushed the 16.0-new-contract_invoice_auto_post branch from c305256 to f03dbc2 Compare October 27, 2023 06:35
Copy link
Contributor

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should look something like this:
[ADD] contract_invoice_auto_post: New module
The PR title should look something like this:
[16.0][ADD] contract_invoice_auto_post: New module

@pedrobaeza
Copy link
Member

I think this can be integrated in the main module, being an optional check. What I don't see is the cron process. The posting should be done immediately after creating the invoice, so no need of a later process.

@manuelcalerosolis manuelcalerosolis changed the title [NEW] Module contract_invoice_auto_post: to 16.0 [ADD] Module contract_invoice_auto_post: to 16.0 Oct 27, 2023
@manuelcalerosolis manuelcalerosolis changed the title [ADD] Module contract_invoice_auto_post: to 16.0 [16.0][ADD] Module contract_invoice_auto_post: to 16.0 Oct 27, 2023
@manuelcalerosolis
Copy link
Author

@pedrobaeza
I also thought about that behavior, but I decided to use the workflow that Odoo has in creating invoices, in addition to having the same options as the standard one.

@pedrobaeza
Copy link
Member

AFAIK, that flow is for posting journal entries in the future, but I don't think here applies.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 25, 2024
@github-actions github-actions bot closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants