IMP: use group product.group_discount_per_so_line instead of base.gro…

[damdam-s]

…up_no_one

[pedrobaeza]

There's not too much sense to add also optional of the field. Just don't add the user to the group instead.

[damdam-s]

@pedrobaeza I understand you point of view. However, some users in the group may not want to see the discount (for view simplification) and that's why I added the optional.
Another reason is to match the optional of the discount_fixed field from #1009 but maybe I should add the optional part in the later PR.
Opinion?

[pedrobaeza]

OK, my only fear here is that someone hides the column, forget it, and then see that the subtotal is "incorrect" not seeing the discount, but it's not a big deal. Please rebase your branch to avoid merge commits though.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[pedrobaeza]

/ocabot merge minor

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1012-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1012-by-pedrobaeza-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[pedrobaeza]

/ocabot merge minor

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1012-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1012-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at d7be9f9. Thanks a lot for contributing to OCA. ❤️