-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] [FIX] sale_commission_partial_settlement: reset agent partial #550
[14.0] [FIX] sale_commission_partial_settlement: reset agent partial #550
Conversation
1ed872c
to
cfaa903
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional ok!
This PR allows recalculation of settlements for invoices for which settlements had previously been created and deleted (before agent invoice creation)
If the invoice line agent does not have any settlement
cfaa903
to
3963032
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM
@pedrobaeza can I ask you to merge this one? Thanks! |
Merging blindly: /ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Appreciate it! |
Congratulations, your PR was merged at 8ee21cf. Thanks a lot for contributing to OCA. ❤️ |
Set the invoice line of the agent as not settled if it does not have any settlement linked to it.
Also, proposing me and my team as maintainers of this module.