[8.0][WIP] Added Earned Value Management Report #107

sudhir-serpentcs · 2017-04-05T03:52:02Z

@elicoidal Added Earned Value Management Report.

elicoidal

Some remarks.
Besides, to be tested.

elicoidal · 2017-04-05T04:01:00Z

business_requirement_earned_value/report/br_earned_value_report.py

+        tools.drop_view_if_exists(cr,
+                                  'business_requirement_earned_value_report')
+        cr.execute("""
+            CREATE VIEW business_requirement_earned_value_report AS (


I see a lot of div by zero potential issues in the current view.

elicoidal · 2017-04-05T04:01:54Z

business_requirement_deliverable_cost/models/business.py

@@ -181,7 +181,7 @@ def _compute_resource_task_total(self):
                    br.mapped('deliverable_lines').mapped(
                        'resource_ids').filtered(
                        lambda r: r.resource_type == 'task').mapped(
-                            'price_total'))


Don't make this change in the PR.

elicoidal · 2017-04-05T04:02:20Z

business_requirement_earned_value/report/__init__.py

@@ -0,0 +1,5 @@
+# -*- coding: utf-8 -*-
+# © 2016 Elico Corp (www.elico-corp.com).


2017 (everywhere)

sudhir-serpentcs · 2017-04-05T13:14:44Z

@elicoidal
Please review code.

elicoidal

Almost there!

elicoidal · 2017-04-05T22:12:33Z

business_requirement_earned_value/report/br_earned_value_report_view.xml

+            <field name="view_id" ref="view_earned_value_graph"/>
+        </record>
+
+        <menuitem action="action_earned_value_report" id="menu_action_deliverable_report"


This report should only visible to the cost group

elicoidal · 2017-04-05T22:33:39Z

almost there!

elicoidal · 2017-04-05T22:33:51Z

please check Travis and Runbot as well

…ess rights

victormmtorres

Please have a check and amend if necessary

victormmtorres · 2017-04-06T05:57:54Z

business_requirement_earned_value/report/br_earned_value_report.py

+                                 readonly=True)
+    res_product = fields.Many2one('product.product', 'Res Product',
+                                  readonly=True)
+    hr_timesheet_product =\


@sudhir-serpentcs layout is not ok.
as example do as here:
hr_timesheet_product = fields.Many2one(
'product.product',
'HR Timesheet Product',
...,)

And amend for the others fields as well

victormmtorres · 2017-04-06T06:00:50Z

business_requirement_earned_value/report/br_earned_value_report.py

+            res.unit_price) as per_variances,
+            pt.remaining_hours,
+            (pt.effective_hours + pt.remaining_hours) as total_expected_time,
+            CASE WHEN (pt.effective_hours + pt.remaining_hours) > 0 THEN


@sudhir-serpentcs if
pt.effective_hours = 0
pt.remaining_hours = 2

condition (pt.effective_hours + pt.remaining_hours) > 0 is true then a division 0/2 on Postgress will cause error, don't you think?

@victormartinelicocorp

no if 0/2
condition should be (pt.remaining_hours) > 0

Yes, please amend

sudhir-serpentcs · 2017-04-06T12:29:46Z

@elicoidal @victormartinelicocorp
Added group and Improved code.
please review code.

elicoidal · 2017-04-07T00:34:27Z

business_requirement_earned_value/report/br_earned_value_report_view.xml

+        </record>
+
+        <menuitem action="action_earned_value_report" id="menu_action_deliverable_report"
+            parent="base.menu_project_report" groups="business_requirement_deliverable_cost.group_business_requirement_cost_control"/>


Please improve formatting (one attribute one line)

elicoidal · 2017-04-07T00:35:24Z

business_requirement_earned_value/__openerp__.py

+{
+    'name': ' Earned Value Management',
+    'category': 'Business Requirements Management',
+    'summary': 'Manage the Business Requirement Deliverables and \


BI report for the based on Earned Value Management

elicoidal

Please add a README file (based on business_requirement module) so that I can create the content

sudhir-serpentcs · 2017-04-07T09:13:05Z

@elicoidal @victormartinelicocorp

Added README.rst and Improved code.

elicoidal · 2017-04-09T11:51:20Z

I made some functional tests and I have several feedbacks.

I cannot relate the report result with the set up I did in the BR.
Here are the DL/RL (101 in total)

Here are the timesheets I have inputed:

Here is the result:

I would have expected:

Planned Hours: 101 instead of 404
Product cost: 25.099 (is a calculation as we cannot get actual cost for multiple lines: cost/hours)
Cost: 2535 instead of 10140
Actual time: 60 instead of 240
Product cost from TS: 30 instead 600 (could be calculation: Actual cost / Actual time)
Actual Cost: 60x30= 1800 instead of 18000
(rest of column are obviously calculated).

Besides can you change the following column string:

Planned Time in RL: Planned Time
Product Cost in RL: Plan. Unit Cost
Actual Time in Timesheet => Actual Time
Product Cost from Timesheet Product => Act. Unit Cost

Other remarks

If there is no timesheet, the report is empty: it should display the BR content with actual time = 0
Name: should be BR name+description

elicoidal

Failed functional tests

sudhir-serpentcs · 2017-04-12T04:27:58Z

@elicoidal @victormartinelicocorp
please review code.

elicoidal · 2017-04-13T01:14:11Z

@sudhir-serpentcs
Retested and still not correct (although seems improving: now it is double instead of quadruple...).

Please check the test I have written in #107 (comment) before submitting for review.

sudhir-serpentcs · 2017-04-13T07:48:29Z

@elicoidal @victormartinelicocorp

please review code

elicoidal · 2017-04-14T02:23:09Z

@sudhir-serpentcs it is better. Some additional feedback:

Please update the titles as in [8.0][WIP] Added Earned Value Management Report #107 (comment)
Project completion should appear as 81 not 0.81 (like % variance)
Variance should be reversed (negative)
Earned Value column seems incorrect

sudhir-serpentcs · 2017-04-14T08:58:53Z

@elicoidal @victormartinelicocorp

please review code

elicoidal · 2017-04-14T11:00:17Z

For #107 (comment) all is clear!
Small details I want to adjust:

Total expected time => Total Exp. time
% Project Completion => % Completion
After that, good to merge :)

sudhir-serpentcs · 2017-04-14T11:34:15Z

@elicoidal @victormartinelicocorp

please review code

elicoidal · 2017-04-14T23:00:08Z

Good job! @sudhir-serpentcs

elicoidal · 2017-04-14T23:01:38Z

@seb-elico @victormartinelicocorp can you review?

elicoidal · 2017-04-16T00:51:30Z

@pedrobaeza @dreispt @seb-elico @victormartinelicocorp Let's move forward?

pedrobaeza · 2017-04-17T07:35:08Z

business_requirement_deliverable_cost/models/business.py

@@ -181,7 +181,7 @@ def _compute_resource_task_total(self):
                    br.mapped('deliverable_lines').mapped(
                        'resource_ids').filtered(
                        lambda r: r.resource_type == 'task').mapped(
-                            'price_total'))


Don't make this change in the PR.

sudhir-serpentcs · 2017-04-17T09:11:33Z

@pedrobaeza @elicoidal

please review code

[WIP] Added Earned Value Management Report

ffb4bdc

elicoidal added the work in progress label Apr 5, 2017

elicoidal added this to the 8.0 milestone Apr 5, 2017

elicoidal suggested changes Apr 5, 2017

View reviewed changes

[IMP] Improved code

fec5d5c

elicoidal suggested changes Apr 5, 2017

View reviewed changes

[ADD]business_requirement_earned_value:- Added security group and acc…

df59e89

…ess rights

victormmtorres suggested changes Apr 6, 2017

View reviewed changes

[IMP] Added security group & Improved code.

51bce20

elicoidal reviewed Apr 7, 2017

View reviewed changes

elicoidal suggested changes Apr 7, 2017

View reviewed changes

[ADD/IMP] added readme and improved code.

d80c739

elicoidal mentioned this pull request Apr 9, 2017

[RFC] Earned Value Management Report #81

Closed

elicoidal added 2 commits April 9, 2017 12:40

Update README (without pictures)

1f4d0f1

Update README.rst

18e76b3

elicoidal added needs review and removed work in progress labels Apr 9, 2017

elicoidal approved these changes Apr 9, 2017

View reviewed changes

elicoidal removed the needs review label Apr 9, 2017

elicoidal suggested changes Apr 9, 2017

View reviewed changes

elicoidal added the needs fixing label Apr 10, 2017

sudhir-serpentcs added 2 commits April 11, 2017 19:59

[IMP]Improved code as per FS requirement

b89879c

[IMP] Fixed Travis

0a32794

[IMP]Improved Earned Value Report Query code.

3b0fdda

[IMP]Improved Earned Value Report Query code.

ef9bcc0

[IMP]Improved Earned Value Report Lable Name.

2c8b746

elicoidal approved these changes Apr 14, 2017

View reviewed changes

elicoidal added needs review and removed needs fixing labels Apr 14, 2017

pedrobaeza approved these changes Apr 17, 2017

View reviewed changes

[IMP]Improved Indentation.

37eb011

pedrobaeza approved these changes Apr 17, 2017

View reviewed changes

pedrobaeza merged commit fe7fe7b into OCA:8.0 Apr 17, 2017

sudhir-serpentcs deleted the 8.0-19936-BR000803-Earned_Value_Management_Report branch July 11, 2017 06:00

ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 22, 2019

[8.0][ADD] Added Earned Value Management Report (OCA#107)

08f21c9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.0][WIP] Added Earned Value Management Report #107

[8.0][WIP] Added Earned Value Management Report #107

sudhir-serpentcs commented Apr 5, 2017

elicoidal left a comment

elicoidal Apr 5, 2017

elicoidal Apr 5, 2017

pedrobaeza Apr 17, 2017

elicoidal Apr 5, 2017

sudhir-serpentcs commented Apr 5, 2017

elicoidal left a comment

elicoidal Apr 5, 2017

elicoidal commented Apr 5, 2017

elicoidal commented Apr 5, 2017

victormmtorres left a comment

victormmtorres Apr 6, 2017

victormmtorres Apr 6, 2017

YogeshMahera-SerpentCS Apr 6, 2017

victormmtorres Apr 6, 2017

sudhir-serpentcs commented Apr 6, 2017

elicoidal Apr 7, 2017

elicoidal Apr 7, 2017

elicoidal left a comment

sudhir-serpentcs commented Apr 7, 2017

elicoidal commented Apr 9, 2017 •

edited

Loading

elicoidal left a comment

sudhir-serpentcs commented Apr 12, 2017

elicoidal commented Apr 13, 2017

sudhir-serpentcs commented Apr 13, 2017

elicoidal commented Apr 14, 2017 •

edited

Loading

sudhir-serpentcs commented Apr 14, 2017

elicoidal commented Apr 14, 2017

sudhir-serpentcs commented Apr 14, 2017

elicoidal commented Apr 14, 2017

elicoidal commented Apr 14, 2017

elicoidal commented Apr 16, 2017

pedrobaeza Apr 17, 2017

sudhir-serpentcs commented Apr 17, 2017

		@@ -0,0 +1,5 @@
		# -- coding: utf-8 --
		# © 2016 Elico Corp (www.elico-corp.com).

[8.0][WIP] Added Earned Value Management Report #107

[8.0][WIP] Added Earned Value Management Report #107

Conversation

sudhir-serpentcs commented Apr 5, 2017

elicoidal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudhir-serpentcs commented Apr 5, 2017

elicoidal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elicoidal commented Apr 5, 2017

elicoidal commented Apr 5, 2017

victormmtorres left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudhir-serpentcs commented Apr 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elicoidal left a comment

Choose a reason for hiding this comment

sudhir-serpentcs commented Apr 7, 2017

elicoidal commented Apr 9, 2017 • edited Loading

elicoidal left a comment

Choose a reason for hiding this comment

sudhir-serpentcs commented Apr 12, 2017

elicoidal commented Apr 13, 2017

sudhir-serpentcs commented Apr 13, 2017

elicoidal commented Apr 14, 2017 • edited Loading

sudhir-serpentcs commented Apr 14, 2017

elicoidal commented Apr 14, 2017

sudhir-serpentcs commented Apr 14, 2017

elicoidal commented Apr 14, 2017

elicoidal commented Apr 14, 2017

elicoidal commented Apr 16, 2017

Choose a reason for hiding this comment

sudhir-serpentcs commented Apr 17, 2017

elicoidal commented Apr 9, 2017 •

edited

Loading

elicoidal commented Apr 14, 2017 •

edited

Loading