-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Adding tags to unittests for account_brand and sale_brand #128
[FIX] Adding tags to unittests for account_brand and sale_brand #128
Conversation
Hi @sbejaoui, @osi-scampbell, |
@sbejaoui are there any news on this topic? |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@rousseldenis or @jbaudoux could you maybe have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change review, LGTM 👍
@sbejaoui Can you merge this 🙏 |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Is there another maintaner who can merge this? |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at ffda2f6. Thanks a lot for contributing to OCA. ❤️ |
If you do
odoo -i account_brand --stop-after-init --test-enable
or
odoo -i sale_brand --stop-after-init --test-enable
The unittests for
account_brand:
TestAccountAnalyticMove.test_move_analytic_account_onchange_brand
TestAccountMove.test_on_change_partner_id
TestBrandMixin.test_default_get
TestBrandMixin.test_reverse_move
sale_brand:
TestSaleOrder.test_create_down_payment_invoice
TestSaleOrder.test_create_invoice
will fail because of missing account.journal entries.
This was already discussed here. OCA/contract#876