Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Adding tags to unittests for account_brand and sale_brand #128

Merged

Conversation

mt-software-de
Copy link
Contributor

If you do
odoo -i account_brand --stop-after-init --test-enable
or
odoo -i sale_brand --stop-after-init --test-enable

The unittests for
account_brand:
TestAccountAnalyticMove.test_move_analytic_account_onchange_brand
TestAccountMove.test_on_change_partner_id
TestBrandMixin.test_default_get
TestBrandMixin.test_reverse_move

sale_brand:
TestSaleOrder.test_create_down_payment_invoice
TestSaleOrder.test_create_invoice

will fail because of missing account.journal entries.
This was already discussed here. OCA/contract#876

@OCA-git-bot
Copy link
Contributor

Hi @sbejaoui, @osi-scampbell,
some modules you are maintaining are being modified, check this out!

@mt-software-de
Copy link
Contributor Author

@sbejaoui are there any news on this topic?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 26, 2023
@mt-software-de
Copy link
Contributor Author

@rousseldenis or @jbaudoux could you maybe have a look?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 2, 2023
Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change review, LGTM 👍

@bosd
Copy link

bosd commented Aug 11, 2023

@sbejaoui Can you merge this 🙏

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 10, 2023
@bosd
Copy link

bosd commented Dec 10, 2023

@sbejaoui Can you merge this 🙏

Is there another maintaner who can merge this?

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-128-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 117383d into OCA:14.0 Dec 10, 2023
2 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ffda2f6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants