[FIX] automation_oca error on record delete #15
+110
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielbarreiros96
force-pushed
the
16.0-fix-automation_oca
branch
2 times, most recently
from
2a33c2c to
9e04281
Compare
rrebollo
approved these changes
Dec 13, 2024
pedrobaeza
reviewed
Dec 13, 2024
arielbarreiros96
force-pushed
the
16.0-fix-automation_oca
branch
2 times, most recently
from
baa85a4 to
f365e0d
Compare
|
Some improvements made to the UI, now orphaned records are shown as orphans on the tree view as well |
arielbarreiros96
force-pushed
the
16.0-fix-automation_oca
branch
3 times, most recently
from
0e693d5 to
f72e66b
Compare
arielbarreiros96
force-pushed
the
16.0-fix-automation_oca
branch
from
f72e66b to
8abbb8c
Compare
Christian-RB
suggested changes
Jan 17, 2025
| } | ||
| ) | ||
| result.append(placeholder.id) | ||
| recs = recs - missing |
There was a problem hiding this comment.
Suggested change
| recs = recs - missing | |
| recs = recs - missing |
| "state": automation_record.state or "done", | ||
| "model": automation_record.model or model, | ||
| "resource_ref": automation_record.resource_ref, | ||
| "is_test": automation_record.is_test or False, |
Comment on lines
+48
to
+51
| missing_res_id = fields.Integer( | ||
| help="ID of the missing referenced resource.", | ||
| readonly=True, | ||
| ) |
There was a problem hiding this comment.
Can we reuse the variable res_id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes to solve this issue #4 when removing items related to automation records, now a placeholder is created for handling the missing relation.