[17.0][FIX] account_reconcile_oca: Fix selection_badge_uncheck to correctly apply the corresponding domain #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @etobella, |
|
Please include in both the PR description and the commit message more details about the issue this is fixing, as I don't understand it. |
… apply the corresponding domain Previously the widget selection_badge_uncheck (wrongly migrated to v17) was not defined correctly, which caused the domain not to be applied, causing that the reconciliation models of any type (instead of those defined as buttons) were shown as buttons. TT52238
victoralmau
force-pushed
the
17.0-fix-account_reconcile_oca-TT52238
branch
from
9c61915 to
4628c5a
Compare
|
Description of commit and PR added to further explain what is happening. |
|
Can you add a screenshot of before and after please 🙏 ? |
|
Of course, added to the PR description. |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at fc48509. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix selection_badge_uncheck to correctly apply the corresponding domain.
Previously the widget selection_badge_uncheck (wrongly migrated to v17) was not defined correctly, which caused the domain not to be applied, causing that the reconciliation models of any type (instead of those defined as buttons) were shown as buttons.
Before
After
Please @CarlosRoca13 can you review it?
@Tecnativa TT52238