[17.0][FIX] account_reconcile_oca: Fixed analytic distribution update #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @etobella, |
|
Missing module name in the commit message. |
This fixes a bug that occurred when both account_reconcile_oca and account_reconcile_model_oca modules were installed. The issue arose when assigning an analytic account and making no further changes, causing the analytic account to not be set correctly. As a result, the reconciliation process failed to create the analytic entries properly. This line: ensures that if the analytic distribution has changed, it will be correctly updated.
BernatObrador
force-pushed
the
17.0-fix-account_reconcile_oca
branch
from
6e75b55 to
7bb5bda
Compare
BernatObrador
changed the title
|
@pedrobaeza Done! |
BernatObrador
changed the title
pedrobaeza
approved these changes
Dec 16, 2024
|
/ocabot merge patch Is this applicable to 16.0? |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at caebfa5. Thanks a lot for contributing to OCA. ❤️ |
|
@pedrobaeza I guess it should! |
|
Can you please do the corresponding PR? |
|
Here is the pr: #769 @pedrobaeza |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that occurred when both account_reconcile_oca and account_reconcile_model_oca modules were installed. The issue arose when assigning an analytic account and making no further changes, causing the analytic account to not be set correctly. As a result, the reconciliation process failed to create the analytic entries properly. This line: ensures that if the analytic distribution has changed, it will be correctly updated.
cc https://github.com/APSL 164854
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review