Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_reconcile: ux improvements #763

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Dec 12, 2024

@OCA-git-bot
Copy link
Contributor

Hi @etobella, @alexis-via,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 12, 2024
@pedrobaeza
Copy link
Member

Please rebase.

@chienandalu
Copy link
Member Author

Done

@@ -181,6 +181,11 @@
string="Transaction Type"
context="{'group_by': 'transaction_type'}"
/>
<filter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<filter
<filter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this is indeed aligned with the above tags formatting... I didn't want to reformat so much to avoid the noise

@pedrobaeza
Copy link
Member

OK, the whole indentation there is mangled, but let's continue:

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-763-by-pedrobaeza-bump-minor, awaiting test results.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also already approved by others in the previous PR.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6070196. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 3a0ee3e into OCA:16.0 Dec 12, 2024
5 of 7 checks passed
@pedrobaeza pedrobaeza deleted the 16.0-reconcile-open branch December 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants