[16.0][FIX] account_mass_reconcile: New environment is initialized when ... #686
Conversation
sergiobstoj
force-pushed
the
16.0-fix-account_mass_reconcile-run_reconcile
branch
from
150f6e5 to
3e1cb11
Compare
sergiobstoj
changed the title
sergiobstoj
changed the title
sergiobstoj
force-pushed
the
16.0-fix-account_mass_reconcile-run_reconcile
branch
from
3e1cb11 to
1fde2d1
Compare
|
/ocabot merge patch |
|
Sorry @sergiocorato you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
@AaronHForgeFlow is it possible to merge this one? |
|
@pedrobaeza is ok for merge? |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-686-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
You have to rebase and check CI errors. |
…en the for loop begins so as not to lose the record of last reconciled items by having "commit_every" > 0 configured
sergiobstoj
force-pushed
the
16.0-fix-account_mass_reconcile-run_reconcile
branch
from
1fde2d1 to
0bd0681
Compare
|
Maybe it's because of a missing patch (due to upstream changes) that is in https://github.com/OCA/account-reconcile/pull/762/files#diff-da3dd7506c5308876f8215b711ebc95dca02516bd0a7b61d04d91b2836de9b12R1002 |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 2452856. Thanks a lot for contributing to OCA. ❤️ |
sergiobstoj
deleted the
16.0-fix-account_mass_reconcile-run_reconcile
branch
New environment is initialized when the for loop begins so as not to lose the record of last reconciled items by having "commit_every" > 0 configured.
When having
reconciliation_commit_everyconfigured as >0There are no records linked on Display items reconciled on the last run
With this fix, having same config (pictures from this PR Runboat):
We can see the las reconciled items:
