Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] account_reconcile_widget : Fix generated reconcile proposal #412

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

TeoGoddet
Copy link

@TeoGoddet TeoGoddet commented Oct 22, 2021

  • fix the value on wich the regex is matched (search on payment_ref instead of name)

@TeoGoddet
Copy link
Author

Fixes #404

With this comment #359 (comment) on #359 i understood that the error is from the 13 to 14 change made on statement lines (name -> payment_ref)

@pedrobaeza
Copy link
Member

Please provide a pull request for each of the 3 things, as some of them are very straight. but not others.

@TeoGoddet TeoGoddet changed the title [14.0] account_reconcile_widget : Fix generated reconcile proposal [14.0][FIX] account_reconcile_widget : Fix generated reconcile proposal Oct 30, 2021
@TeoGoddet
Copy link
Author

Hi ! Is it small enough ?

@pedrobaeza
Copy link
Member

I still see 2 changes, and I don't understand the decimal separator one. If you leave the other, I will fast-track it, and then we can discuss about the other in a new PR.

@TeoGoddet
Copy link
Author

Ok, I let only the first change
let's discuss the decimal separator on #420

@pedrobaeza pedrobaeza added this to the 14.0 milestone Oct 30, 2021
@pedrobaeza
Copy link
Member

Fast-tracking this one as the recurring name>payment_ref bug:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-412-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ec90660 into OCA:14.0 Oct 30, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d7c44d6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants