-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG] - account_payment_show_invoice #431
base: 14.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: account-payment-11.0/account-payment-11.0-account_payment_show_invoice Translate-URL: https://translation.odoo-community.org/projects/account-payment-11-0/account-payment-11-0-account_payment_show_invoice/de/
There was a fix in `account_payment` module that changed the way how `multi` field is computed. In the case of `test_2_two_invoices_register_payment` in `account_payment_multi_deduction` module, it's evaluated to True and this made the payment registration `amount` field readonly. https://github.com/odoo/odoo/blob/867de2bad3f6096098cb47611bcf0096b85e24b8/addons/account/models/account_payment.py#L303 Now, this operation raises an error. https://github.com/OCA/account-payment/blob/4f7c56d8f501dde75a04f61076a27d2b011274c0/account_payment_multi_deduction/tests/test_payment_multi_deduction.py#L99 https://travis-ci.org/github/OCA/account-payment/jobs/658790207#L1020 multi=True caused this error too as the payment register is not grouping invoices https://travis-ci.org/github/OCA/account-payment/jobs/658790207#L1109
Currently translated at 100.0% (2 of 2 strings) Translation: account-payment-12.0/account-payment-12.0-account_payment_show_invoice Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_payment_show_invoice/pt/
50f1cd7
to
0b68139
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
To be fair, this shows the invoice reference/memo, not the invoice number. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@netfxtech Of course. Could you approve this ? |
@sbejaoui @adrienpeiffer Could you rebase ? |
/ocabot rebase |
Sorry @sergiocorato you are not allowed to rebase. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref
shown here is related to payment move, so unuseful.
Please restore field as prior version.
No description provided.