Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][TMP] this is just a CI test #1820

Closed
wants to merge 1 commit into from
Closed

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Oct 22, 2024

THIS IS JUST A TEST

I want to check if the CI really stopped passing on 14.0 (EDIT: it's also broken on 15.0 and 16.0!)
(and understand why the merge of #1782 failed)

@rvalyi rvalyi changed the title [TMP] this is just a CI test [14.0][TMP] this is just a CI test Oct 22, 2024
@rvalyi
Copy link
Member Author

rvalyi commented Oct 22, 2024

so yes the CI is broken on:

Here on 14.0 we got this error in this PR were I didn't touch anything sensible in this PR:
https://github.com/OCA/account-invoicing/actions/runs/11469503360/job/31916857990?pr=1820#step:8:726


 2024-10-22 22:31:11,735 565 INFO odoo odoo.addons.account_invoice_line_description.tests.test_account_invoice_line_description: Starting TestAccountInvoiceLineDescription.test_onchange_product_id_sale ... 
2024-10-22 22:31:12,139 565 INFO odoo odoo.models.unlink: User #1 deleted ir.model.data records with IDs: [4821, 4822] 
2024-10-22 22:31:12,140 565 INFO odoo odoo.models.unlink: User #1 deleted res.currency.rate records with IDs: [2, 1] 
2024-10-22 22:31:12,144 565 INFO odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: Starting TestAccountMovePricelist.test_account_invoice_change_pricelist ... 
2024-10-22 22:31:12,313 565 INFO odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: Starting TestAccountMovePricelist.test_account_invoice_fixed_pricelist_with_discount_secondary_currency ... 
2024-10-22 22:31:12,496 565 INFO odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: Starting TestAccountMovePricelist.test_account_invoice_fixed_pricelist_without_discount_secondary_currency ... 
2024-10-22 22:31:12,704 565 INFO odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: ====================================================================== 
2024-10-22 22:31:12,704 565 ERROR odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: FAIL: TestAccountMovePricelist.test_account_invoice_fixed_pricelist_without_discount_secondary_currency
Traceback (most recent call last):
  File "/__w/account-invoicing/account-invoicing/account_invoice_pricelist/tests/test_account_move_pricelist.py", line 319, in test_account_invoice_fixed_pricelist_without_discount_secondary_currency
    self.assertAlmostEqual(invoice_line.price_unit, 65.41)
AssertionError: 100.0 != 65.41 within 7 places
 
2024-10-22 22:31:12,704 565 INFO odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: Starting TestAccountMovePricelist.test_account_invoice_pricelist ... 
2024-10-22 22:31:12,719 565 INFO odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: Starting TestAccountMovePricelist.test_account_invoice_pricelist_with_discount_secondary_currency ... 
2024-10-22 22:31:12,899 565 INFO odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: ====================================================================== 
2024-10-22 22:31:12,899 565 ERROR odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: FAIL: TestAccountMovePricelist.test_account_invoice_pricelist_with_discount_secondary_currency
Traceback (most recent call last):
  File "/__w/account-invoicing/account-invoicing/account_invoice_pricelist/tests/test_account_move_pricelist.py", line 295, in test_account_invoice_pricelist_with_discount_secondary_currency
    self.assertAlmostEqual(invoice_line.price_unit, 58.87)
AssertionError: 90.00000000000004 != 58.87 within 7 places
 
2024-10-22 22:31:12,899 565 INFO odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: Starting TestAccountMovePricelist.test_account_invoice_pricelist_without_discount ... 
2024-10-22 22:31:13,085 565 INFO odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: Starting TestAccountMovePricelist.test_account_invoice_pricelist_without_discount_secondary_currency ... 
2024-10-22 22:31:13,294 565 INFO odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: ====================================================================== 
2024-10-22 22:31:13,294 565 ERROR odoo odoo.addons.account_invoice_pricelist.tests.test_account_move_pricelist: FAIL: TestAccountMovePricelist.test_account_invoice_pricelist_without_discount_secondary_currency
Traceback (most recent call last):
  File "/__w/account-invoicing/account-invoicing/account_invoice_pricelist/tests/test_account_move_pricelist.py", line 303, in test_account_invoice_pricelist_without_discount_secondary_currency
    self.assertAlmostEqual(invoice_line.price_unit, 65.41)
AssertionError: 100.0 != 65.41 within 7 places

cc @OCA/accounting-maintainers @mbcosta @marcelsavegnago @antoniospneto @renatonlima

@rvalyi
Copy link
Member Author

rvalyi commented Oct 23, 2024

Strangely the bug in the tests disappeared. Seems to be a date pricelist heisen bug. But closing this for now.

@rvalyi rvalyi closed this Oct 23, 2024
@pedrobaeza
Copy link
Member

It's due to tests not resilient to timezones, so around midnight CET/CEST, they failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants