-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] account_invoice_customer_no_autofollow #1781
base: 16.0
Are you sure you want to change the base?
[16.0][MIG] account_invoice_customer_no_autofollow #1781
Conversation
/ocabot migration account_invoice_customer_no_autofollow |
47e5bb0
to
7d62b14
Compare
7d62b14
to
fa49ef7
Compare
We may want to rename this module to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional LGTM. Pls check the comment regarding maintainers.
@sbidoul this is a good idea. However I wouldn't do this to avoid potential migration issues. |
I wonder why such module is not more popular. I kind of feel I'm missing something obvious... @StefanRijnhart since you reviewed the same for sale orders, you may be interested in this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I see no issues with the rename, because there is no data associated with this module. It would be nice to see the config parameter renamed on migration (after using openupgrade's rename_modules) or (re)installation.
Yup, this means that there we should add a migration script
@StefanRijnhart Yup, actually we can keep the existing config parameter name or add a migration script it we really need to rename it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello @sbidoul
We don't have and request in clients. They have customers as followers and there are not any problem reported in many years. 🤔 Best regards! |
This PR has the |
No description provided.