Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] account_invoice_triple_discount: Discount rounding #1606

Merged
merged 1 commit into from
Nov 24, 2023
Merged

[FIX] account_invoice_triple_discount: Discount rounding #1606

merged 1 commit into from
Nov 24, 2023

Conversation

SirAionTech
Copy link

@SirAionTech SirAionTech commented Nov 15, 2023 •
edited
Loading

The added tests show how those trivial use-cases are failing before this PR.

@SirAionTech SirAionTech force-pushed the 16.0-fix-account_invoice_triple_discount-restore_round branch from 6ceace1 to a58b33b Compare November 15, 2023 14:32
@SirAionTech SirAionTech force-pushed the 16.0-fix-account_invoice_triple_discount-restore_round branch from a58b33b to 30fd111 Compare November 15, 2023 14:34
@SirAionTech SirAionTech marked this pull request as ready for review November 15, 2023 14:41
This was referenced Nov 15, 2023
Open
Closed
@francesco-ooops
Copy link
Contributor

@SirAionTech is this different from #1256 and related back- and fw-portings?

@SirAionTech
Copy link
Author

@SirAionTech is this different from #1256 and related back- and fw-portings?

Yes, it looks like that PR is already included in 16.0.

@francesco-ooops
Copy link
Contributor

@sergiocorato @ferran-S73 fyi

aleuffre
aleuffre approved these changes Nov 17, 2023
View reviewed changes
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

odooNextev
odooNextev approved these changes Nov 20, 2023
View reviewed changes
Copy link

@odooNextev odooNextev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francesco-ooops
Copy link
Contributor

@eLBati @sergiocorato @OCA/accounting-maintainers good for merge?

@francesco-ooops
Copy link
Contributor

@almumu can you take a look at this? thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@tafaRU anything against this one?

@francesco-ooops
Copy link
Contributor

@pedrobaeza does this approach look reasonable to you?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 24, 2023
@pedrobaeza
Copy link
Member

I can't say. Merging due to existing reviews and nothing specially blocking seen.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1606-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 03ad705 into OCA:16.0 Nov 24, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bc115ad. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSLabIt GSLabIt GSLabIt approved these changes

@aleuffre aleuffre aleuffre approved these changes

@odooNextev odooNextev odooNextev approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@SirAionTech @francesco-ooops @OCA-git-bot @pedrobaeza @GSLabIt @aleuffre @odooNextev