[14.0] FIX account_invoice_triple_discount - _recompute_tax_lines involving only relevant lines: invoice_line_ids

[eLBati]

Ref OCA/l10n-italy#3681

[odooNextev]

LGTM

[francesco-ooops]

@eLBati can you add module name in PR title and commit name?

[eLBati]

@eLBati can you add module name in PR title and commit name?

Done

[francesco-ooops]

cc @SirAionTech since you previously reviewed #1442

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[francesco-ooops]

@OCA/accounting-maintainers can this be merged please? thank you!

[francesco-ooops]

@tafaRU related to OCA/l10n-italy#3681

[sergiocorato]

LGTM

[sergiocorato]

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1592-by-sergiocorato-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at da6d5d0. Thanks a lot for contributing to OCA. ❤️

[francesco-ooops]

@eLBati @sergiocorato this PR has broken tests for https://github.com/OCA/sale-workflow/tree/14.0/sale_triple_discount , see https://github.com/OCA/sale-workflow/actions/runs/6823495365/job/18557544202?pr=2771#step:8:1414

[francesco-ooops]

@SirAionTech in your opinion, does this need to be fw-ported to v16?

[SirAionTech]

@SirAionTech in your opinion, does this need to be fw-ported to v16?

I haven't had time recently to look into this.
If I remember correctly from the long thread in #1442, I was not very convinced of this change in the first place because I don't see how this is fixing this module.
So I have some concerns about back/forward-porting this.

Maybe a little recap of the history of this change might help understanding if it is needed in the future (16.0):
this change was originally needed for fixing the migration of l10n_it_fatturapa_out_triple_discount (OCA/l10n-italy#3269).

It just happens that I have done the migration of the same module to 16.0(OCA/l10n-italy#3720); since this last PR is ok without this, I'd assume that this is not needed in 16.0.

TL;DR: no

[francesco-ooops]

@sergiocorato @OCA/accounting-maintainers all PRs in sale-workflow v14 are failing due to this PR.

Option 1) merge fix #1605

Option 2) revert this change due to doubts expressed regarding to PR and fix in #1592 (comment), #1605 (comment), #1605 (comment)

Personally I find the second more favourable. This problem is not present in v16.