[9.0][NEW] sale_timesheet_invoice_description: New module #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/ | ||
| account-invoicing/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us smashing it by providing a detailed and welcomed feedback `here <https://github.com/OCA/ |
There was a problem hiding this comment.
You can simplify this part (check the new template)
|
non blocking remark. other than that 👍 |
|
|
||
| To use this module, you need to: | ||
|
|
||
| #. Go to *Sales -> Sale Orders* and create a new Sale Order. |
There was a problem hiding this comment.
s/Sale Orders/Sales Orders (2 times)
| _inherit = 'sale.order' | ||
|
|
||
| timesheet_invoice_description = fields.Selection( | ||
| '_get_timesheet_invoice_description', default='111') |
There was a problem hiding this comment.
We have said that the default should be put at company level and accessible from the Sales > Settings menu.
| @@ -14,6 +14,8 @@ Usage | |||
|
|
|||
| To use this module, you need to: | |||
|
|
|||
| #. Go to *Sales -> Configuration -> Settings -> Quotations & Sales* and set | |||
There was a problem hiding this comment.
This paragraph should go in the Configuration section and include the word "Default".
|
@pedrobaeza changes done |
| @api.model | ||
| def _get_timesheet_invoice_description(self): | ||
| return [ | ||
| ('000', _('')), |
…d when previous invoices exists
|
@pedrobaeza changes done |
|
Please fix module tests (probably you need to set a value for "invoice description" in the test sales order). |
|
Tested in runbot 👍 |
|
Please, don't merge yet. |
|
Forget my last comment. I didn't want write it in this pull request. |
|
👍 |
dcorio
pushed a commit
to abstract-open-solutions/account-invoicing
that referenced
this pull request
Oct 20, 2016
[ADD] sale_timesheet_invoice_description: New module
ernestotejeda
pushed a commit
to Tecnativa/account-invoicing
that referenced
this pull request
Nov 25, 2018
[ADD] sale_timesheet_invoice_description: New module
ernestotejeda
pushed a commit
to Tecnativa/account-invoicing
that referenced
this pull request
Nov 26, 2018
[ADD] sale_timesheet_invoice_description: New module
manuelcalerosolis
pushed a commit
to Tecnativa/account-invoicing
that referenced
this pull request
Feb 24, 2020
[ADD] sale_timesheet_invoice_description: New module
kongrattapong
pushed a commit
to kongrattapong/account-invoicing
that referenced
this pull request
Jul 1, 2020
[ADD] sale_timesheet_invoice_description: New module
clementmbr
pushed a commit
to akretion/account-invoicing
that referenced
this pull request
Mar 24, 2021
[ADD] sale_timesheet_invoice_description: New module
clementmbr
pushed a commit
to akretion/account-invoicing
that referenced
this pull request
Nov 9, 2021
[ADD] sale_timesheet_invoice_description: New module
clementmbr
pushed a commit
to akretion/account-invoicing
that referenced
this pull request
Nov 9, 2021
[ADD] sale_timesheet_invoice_description: New module
LudLaf
pushed a commit
to Tecnativa/account-invoicing
that referenced
this pull request
Aug 30, 2022
[ADD] sale_timesheet_invoice_description: New module
LudLaf
pushed a commit
to Tecnativa/account-invoicing
that referenced
this pull request
Nov 10, 2022
[ADD] sale_timesheet_invoice_description: New module
jasperjumelet
pushed a commit
to jasperjumelet/account-invoicing
that referenced
this pull request
Mar 14, 2023
[ADD] sale_timesheet_invoice_description: New module
dsolanki-initos
pushed a commit
to initOS/account-invoicing
that referenced
this pull request
Mar 27, 2023
[ADD] sale_timesheet_invoice_description: New module
dsolanki-initos
pushed a commit
to initOS/account-invoicing
that referenced
this pull request
Jun 8, 2023
[ADD] sale_timesheet_invoice_description: New module
azoellner
pushed a commit
to initOS/account-invoicing
that referenced
this pull request
Oct 25, 2023
[ADD] sale_timesheet_invoice_description: New module
MarioLM-23
pushed a commit
to MarioLM-23/account-invoicing
that referenced
this pull request
Apr 18, 2024
[ADD] sale_timesheet_invoice_description: New module
rconjour
pushed a commit
to wesolved/account-invoicing
that referenced
this pull request
Jul 10, 2024
[ADD] sale_timesheet_invoice_description: New module
rconjour
pushed a commit
to wesolved/account-invoicing
that referenced
this pull request
Dec 2, 2024
[ADD] sale_timesheet_invoice_description: New module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replace OCA/sale-workflow#298