[14.0] ADD account_receipt_sale #1267

eLBati · 2022-10-18T06:59:05Z

Depends on #1260 and #1427

primes2h

Vedi anche OCA/l10n-italy#2722 (comment)

primes2h · 2023-01-18T14:29:49Z

account_receipt_sale/models/account_fiscal_position.py

+from odoo import models, fields, api
+
+
+class Position(models.Model):
+    _inherit = "account.fiscal.position"
+    receipts = fields.Boolean(string='Receipts')
+
+    @api.model
+    def get_receipts_fiscal_pos(self, company_id=None):
+        if not company_id:
+            company_id = self.env.user.company_id
+        receipt_fiscal_pos = self.search(
+            [
+                ('company_id', '=', company_id.id),
+                ('receipts', '=', True),
+            ],
+            limit=1
+        )
+        if not receipt_fiscal_pos:
+            # Fall back to fiscal positions without company
+            receipt_fiscal_pos = self.search(
+                [
+                    ('company_id', '=', False),
+                    ('receipts', '=', True),
+                ],
+                limit=1
+            )
+
+        return receipt_fiscal_pos


Visto quanto indicato qui direi che questa parte non serve.
O quantomeno non dovrebbe stare in questo modulo, se vogliamo che lo stesso corrisponda allo scopo di l10n_it_corrispettivi_sale della 12.0.

The purpose of account_receipt_sale is essentially in its DESCRIPTION.rst
so it includes parts of l10n_it_corrispettivi and l10n_it_corrispettivi_sale

primes2h · 2023-01-18T14:32:19Z

account_receipt_sale/models/partner.py

+from odoo import models, fields, api
+
+
+class Partner(models.Model):
+    _inherit = "res.partner"
+    use_receipts = fields.Boolean(string='Use Receipts')
+
+    @api.onchange('use_receipts')
+    def onchange_use_receipts(self):
+        if self.use_receipts:
+            # Partner is receipts, assign a receipts
+            # fiscal position only if there is none
+            if not self.property_account_position_id:
+                company = self.company_id or self.env.company
+                self.property_account_position_id = \
+                    self.env['account.fiscal.position'] \
+                        .get_receipts_fiscal_pos(company)
+        else:
+            # Unset the fiscal position only if it was receipts
+            if self.property_account_position_id.receipts:
+                self.property_account_position_id = False


Vedi sopra.

primes2h · 2023-01-18T14:32:57Z

account_receipt_sale/views/account_fiscal_position_views.xml

+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <record id="view_account_position_form" model="ir.ui.view">
+        <field name="name">account.fiscal.position.form.receipts</field>
+        <field name="model">account.fiscal.position</field>
+        <field name="type">form</field>
+        <field name="inherit_id" ref="account.view_account_position_form"/>
+        <field name="arch" type="xml">
+            <field name="company_id" position="after">
+                <field name="receipts"/>
+            </field>
+        </field>
+    </record>
+</odoo>


Vedi sopra.

primes2h · 2023-01-18T14:33:17Z

account_receipt_sale/views/partner_views.xml

+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <record id="view_partner_form" model="ir.ui.view">
+        <field name="name">res.partner.form.receipts</field>
+        <field name="model">res.partner</field>
+        <field name="inherit_id" ref="account.view_partner_property_form"/>
+        <field name="groups_id" eval="[(4, ref('account.group_account_manager'))]"/>
+        <field name="arch" type="xml">
+            <group name="fiscal_information" position="inside">
+                <field name="use_receipts"/>
+            </group>
+        </field>
+    </record>
+</odoo>


Vedi sopra.

primes2h · 2023-01-19T08:03:12Z

I'm sorry for comments in italian language, I tought i was in the italian repo (l10n-italy). 😅

rafaelbn · 2023-02-02T20:10:48Z

/ocabot rebase

rafaelbn · 2023-02-02T20:11:06Z

@eLBati hello! Dependency merged!

tafaRU · 2023-07-20T07:23:29Z

@eLBati could you please rebase in order to rebuild runboat?

SerM11

Tested :

From back end create correctly the receipts when the flag on partner is set.
Also from e-commerce is possible to create a receipt for the SO linked to a partner with receipt flag active

On receipts don't see any information about the journal used

I don't see any menu in invoicing module for access to the receipts list (but from the single partner is possible to access their ones)

the flag "group_show_sale_receipts" (under configuration / settings / invoice --> Sale Receipt Enterprise) is a enterprise feature and require an upgrade to enterprise environment in v14 (in v16 no more).

SerM11 · 2023-08-03T07:41:11Z

@eLBati any news? thanks

SirTakobi · 2023-08-04T08:17:52Z

I don't see any menu in invoicing module for access to the receipts list (but from the single partner is possible to access their ones)

Here is the menu:

you need the group account.group_sale_receipts in order to see it, have a look at https://github.com/odoo/odoo/blob/960e61e7451ef8dacd3aaa70bb148240762ab461/addons/account/views/account_menuitem.xml#L13

SerM11

@SirTakobi thank you, can you please add this step to the readme / instructions of the module?

I did other functional test and looks good to me.
:)

SirTakobi · 2023-08-04T08:44:28Z

can you please add this step to the readme / instructions of the module?

cc @eLBati

Sashimi22

Functional test ok

… to fiscal position

Currently translated at 66.7% (2 of 3 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_corrispettivi_sale Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_corrispettivi_sale/it/

Currently translated at 100.0% (3 of 3 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_corrispettivi_sale Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_corrispettivi_sale/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_corrispettivi_sale Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_corrispettivi_sale/

…is used when sale orders are created programmatically, like from e-commerce

)

…s dangerous recomputations

account_receipt_sale (LGPL-3) depends on account_receipt_base (AGPL-3)

OCA-git-bot · 2024-03-05T20:45:32Z

Congratulations, PR rebased to 14.0.

sergiocorato · 2024-03-05T21:03:24Z

/ocabot merge nobump

OCA-git-bot · 2024-03-05T21:03:32Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1267-by-sergiocorato-bump-nobump, awaiting test results.

OCA-git-bot · 2024-03-05T21:17:33Z

Congratulations, your PR was merged at fbc68ce. Thanks a lot for contributing to OCA. ❤️

This was referenced Oct 18, 2022

[14.0] porting l10n_it_corrispettivi OCA/l10n-italy#2972

Closed

[RFC] refactoring l10n_it_corrispettivi, integrazione con ricevute Odoo OCA/l10n-italy#2722

Open

eLBati force-pushed the 14.0-account_receipt_sale branch from 275d6a1 to 7aaa818 Compare October 18, 2022 14:15

eLBati mentioned this pull request Oct 19, 2022

Migration to version 14.0 OCA/l10n-italy#1905

Open

74 tasks

SirTakobi mentioned this pull request Oct 21, 2022

[FIX] account_receipt_sale: Migration, receipt buttons and invoice preparation eLBati/account-invoicing#7

Closed

eLBati force-pushed the 14.0-account_receipt_sale branch from 7aaa818 to 4ca4300 Compare October 21, 2022 15:20

primes2h reviewed Jan 18, 2023

View reviewed changes

eLBati mentioned this pull request Feb 1, 2023

[14.0] ADD account_receipt_journal: Define and use journals dedicated to receipts #1260

Merged

rafaelbn added this to the 14.0 milestone Feb 2, 2023

rafaelbn added the needs review label Feb 2, 2023

eLBati force-pushed the 14.0-account_receipt_sale branch from 828fa64 to 8b78bcb Compare March 21, 2023 06:43

eLBati marked this pull request as ready for review March 21, 2023 06:44

eLBati force-pushed the 14.0-account_receipt_sale branch from bc53956 to 05b1ff0 Compare March 31, 2023 12:57

eLBati force-pushed the 14.0-account_receipt_sale branch from 15cfff9 to 34cf19e Compare July 21, 2023 10:34

SerM11 reviewed Jul 21, 2023

View reviewed changes

SerM11 mentioned this pull request Jul 24, 2023

[14.0] [ADD] new module account_portal_receipt #873

Closed

SerM11 approved these changes Aug 4, 2023

View reviewed changes

Sashimi22 approved these changes Aug 7, 2023

View reviewed changes

OCA-git-bot added the approved label Aug 7, 2023

eLBati force-pushed the 14.0-account_receipt_sale branch from 34cf19e to c2e5d5d Compare January 10, 2024 09:41

OCA-git-bot and others added 21 commits March 5, 2024 20:45

[UPD] README.rst

6a1be01

[FIX] l10n_it_corrispettivi_sale: Change corrispettivi flag according…

7061de8

… to fiscal position

l10n_it_corrispettivi_sale 12.0.1.0.1

e3916b4

Translated using Weblate (Italian)

7bebb77

Currently translated at 66.7% (2 of 3 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_corrispettivi_sale Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_corrispettivi_sale/it/

- modifiy corrispettivi only if fiscal_position exists

3278953

[UPD] README.rst

4ece5a8

l10n_it_corrispettivi_sale 12.0.1.0.2

a32ab97

merge PR 1264 1717 1728 1737 1739

a2e9422

Translated using Weblate (Italian)

aeb798d

Currently translated at 100.0% (3 of 3 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_corrispettivi_sale Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_corrispettivi_sale/it/

Reformatted after template update

7d44670

Manually fix manifest website key

64fb567

ADD account_receipt_sale, ported from l10n_it_corrispettivi_sale

dcac40d

[FIX] account_receipt_sale: Migration from l10n_it_corrispettivi(_sale)

c0cfb9f

[IMP] account_receipt_sale: Invoiced quantity and buttons in order

baf8bef

[IMP] account_receipt_sale: Prepare invoice instead of forcing receipt

47e4e4d

Set receipts sale.order field at creation and modification too. This …

6daf71c

…is used when sale orders are created programmatically, like from e-commerce

[IMP] account_receipt_sale: black, isort, prettier

101f11e

[FIX] account_receipt_sale: Receipt refunds have negative quantities (#8

205e3ec

)

REF invert_receipt_refund_quantity using SQL because using ORM implie…

e7ffc03

…s dangerous recomputations

[IMP] account_receipt_sale: Move Partner and Fiscal Position to base

5a7400f

account_receipt_sale (LGPL-3) depends on account_receipt_base (AGPL-3)

OCA-git-bot force-pushed the 14.0-account_receipt_sale branch from c0ce362 to 5a7400f Compare March 5, 2024 20:45

OCA-git-bot added the bot is merging ⏳ label Mar 5, 2024

OCA-git-bot merged commit 220570b into OCA:14.0 Mar 5, 2024
7 of 9 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0] ADD account_receipt_sale #1267

[14.0] ADD account_receipt_sale #1267

eLBati commented Oct 18, 2022 •

edited

Loading

primes2h left a comment

primes2h Jan 18, 2023

eLBati Feb 1, 2023

primes2h Jan 18, 2023

primes2h Jan 18, 2023

primes2h Jan 18, 2023

primes2h commented Jan 19, 2023

rafaelbn commented Feb 2, 2023

rafaelbn commented Feb 2, 2023

tafaRU commented Jul 20, 2023

SerM11 left a comment

SerM11 commented Aug 3, 2023

SirTakobi commented Aug 4, 2023

SerM11 left a comment

SirTakobi commented Aug 4, 2023

Sashimi22 left a comment

OCA-git-bot commented Mar 5, 2024

sergiocorato commented Mar 5, 2024

OCA-git-bot commented Mar 5, 2024

OCA-git-bot commented Mar 5, 2024

[14.0] ADD account_receipt_sale #1267

[14.0] ADD account_receipt_sale #1267

Conversation

eLBati commented Oct 18, 2022 • edited Loading

primes2h left a comment

Choose a reason for hiding this comment

primes2h Jan 18, 2023

Choose a reason for hiding this comment

eLBati Feb 1, 2023

Choose a reason for hiding this comment

primes2h Jan 18, 2023

Choose a reason for hiding this comment

primes2h Jan 18, 2023

Choose a reason for hiding this comment

primes2h Jan 18, 2023

Choose a reason for hiding this comment

primes2h commented Jan 19, 2023

rafaelbn commented Feb 2, 2023

rafaelbn commented Feb 2, 2023

tafaRU commented Jul 20, 2023

SerM11 left a comment

Choose a reason for hiding this comment

SerM11 commented Aug 3, 2023

SirTakobi commented Aug 4, 2023

SerM11 left a comment

Choose a reason for hiding this comment

SirTakobi commented Aug 4, 2023

Sashimi22 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Mar 5, 2024

sergiocorato commented Mar 5, 2024

OCA-git-bot commented Mar 5, 2024

OCA-git-bot commented Mar 5, 2024

eLBati commented Oct 18, 2022 •

edited

Loading