Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] account_invoice_check_total: Proper tagging of unittests #1246

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[14.0][FIX] account_invoice_check_total: Proper tagging of unittests #1246

merged 1 commit into from
Nov 28, 2023

Conversation

mt-software-de
Copy link
Contributor

@mt-software-de mt-software-de commented Sep 26, 2022 •
edited
Loading

After this change the tests will also run successful
If you do only
odoo -i account_account_invoice_check_total --stop-after-init --test-enable

Now they fail because of missing account.journal entries

This was also done for OCA/contract#876

@mt-software-de
Copy link
Contributor Author

@pedrobaeza could please review this changes?

@pedrobaeza
Copy link
Member

Sorry, I don't use these modules. You should review other PRs and ask in exchange that they review yours.

@mt-software-de mt-software-de changed the title [FIX] Adding tags to unittests for account_account_invoice_check_total and account_invoice_mode_at_shipping [14.0][FIX] account_invoice_check_total: Proper tagging of unittests Nov 28, 2023
@mt-software-de
Copy link
Contributor Author

@jbaudoux and @etobella could review and merge this one?

etobella
etobella reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that error should only be raised on fresh installations, but you are right

AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@etobella
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1246-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 0e62b1d into OCA:14.0 Nov 28, 2023
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5255675. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mt-software-de @pedrobaeza @etobella @OCA-git-bot @AaronHForgeFlow