Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account_avatax: Tax rounding not applied in Invoice #313

Closed
wants to merge 1 commit into from

Conversation

atchuthan
Copy link
Member

Steps to reproduce

  • Let's assume that a SO was created, and we received tax as $15.14 and 9.25% for $163.75(which should be $15.146875 ~ 15.15 as per calculation) but we take the tax from avatax as it is and set it in SO.
  • Create an invoice and compute tax with Avatax with tax as $15.15(tax calculated based on odoo) and will have $0.1 residual amount difference
  • Recompute tax once again, and the tax amount changes to $15.14(Tax amount from Avatax).

Our fix is to send the context when the taxes are added to the Invoice line.

cc: @SodexisTeam @dreispt

@OCA-git-bot
Copy link
Contributor

Hi @dreispt,
some modules you are maintaining are being modified, check this out!

@metaminux
Copy link

Hi @atchuthan

I'm trying to see if #304 is related but I've trouble reproducing your issue.

Assuming your Avalara advanced settings in On for Control Rounding.
avalara_control_rounding

I can get the amount you're describing for a customer in Tenessee (9.25% for $163.75 gives me $15.14 sales taxes)
tenessee_sale_order

When creating the invoice, Odoo computes a $15.15 tax (not using the amount computed for SO, see #304).
tenessee_draft_invoice

But as soon as I click on Compute Tax or Post, amounts are retrieved from Avatax and there is no residual difference amount.
tenessee_draft_recomputed

So I can't see the effect of your commit.

Can you tell me where I'm wrong ?

@dreispt
Copy link
Member

dreispt commented Sep 9, 2022

Hi @atchuthan these rounding issues is also a concern for me.
Can you share a particular example we can try too: specific delivery address and amount.
Thank you

@atchuthan atchuthan force-pushed the 14.0-fix-tax-rounding branch from 8c1ce71 to 082120e Compare September 14, 2022 07:38
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 15, 2023
@github-actions github-actions bot closed this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants