-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] account_journal_restrict_mode: Migration to 18.0 #1991
base: 18.0
Are you sure you want to change the base?
[18.0][MIG] account_journal_restrict_mode: Migration to 18.0 #1991
Conversation
Currently translated at 100.0% (4 of 4 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_journal_restrict_mode Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_journal_restrict_mode/es/
Currently translated at 100.0% (4 of 4 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_journal_restrict_mode Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_journal_restrict_mode/it/
LGTM now that odoo/odoo@b48e66e simplifies the code |
for rec in self: | ||
if not rec.restrict_mode_hash_table: | ||
raise UserError( | ||
self.env._("Journal %s must have Lock Posted Entries enabled.") % rec.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MiquelRForgeFlow wow, did not see that coming 😄 thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when the pre-commit check is passed
5aec5e2
to
242c37e
Compare
Standard migration