Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_journal_restrict_mode: Migration to 18.0 #1991

Open
wants to merge 13 commits into
base: 18.0
Choose a base branch
from

Conversation

SaraDForgeFlow
Copy link

Standard migration

@AaronHForgeFlow
Copy link
Contributor

LGTM now that odoo/odoo@b48e66e simplifies the code

for rec in self:
if not rec.restrict_mode_hash_table:
raise UserError(
self.env._("Journal %s must have Lock Posted Entries enabled.") % rec.name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiquelRForgeFlow wow, did not see that coming 😄 thanks!

Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the pre-commit check is passed

@SaraDForgeFlow SaraDForgeFlow force-pushed the 18.0-mig-account_journal_restrict_mode branch from 5aec5e2 to 242c37e Compare December 17, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants