[15.0][FIX] account_asset_management: Allow to unlink w/o billing permission #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdauden
approved these changes
Jun 18, 2024
victoralmau
approved these changes
Jun 19, 2024
rvalyi
approved these changes
Jun 19, 2024
Some users may be allowed to unlink invoices without billing access, but with current code, they are not able, as the asset line check is done without sudo, and other users except billing or higher ones aren't allowed to access to that model. TT49673
pedrobaeza
force-pushed
the
15.0-fix-account_asset_management-access_error
branch
from
8b8f2af to
660f05f
Compare
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at c70c04a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users may be allowed to unlink invoices without billing access, but with current code, they are not able as the asset line check is done without sudo, and other users except billing or higher ones aren't allowed to access to that model.
@Tecnativa TT49673