Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG]account_fiscal_year:Migration to 17.0 #1834

Merged
merged 54 commits into from
Jul 17, 2024
Merged

[17.0][MIG]account_fiscal_year:Migration to 17.0 #1834

merged 54 commits into from
Jul 17, 2024

Conversation

bizzappdev
Copy link
Contributor

No description provided.

damdam-s and others added 30 commits March 18, 2024 11:24
@damdam-s @bizzappdev
[ADD] add module "account_fiscal_year"
7035b34
@lmignon @bizzappdev
[FIX] Tests
a0bc223
@damdam-s @bizzappdev
[FIX*IMP] account_fiscal_year
6b90433 
* Add contributors to README
* try to find a FY start date according to the start date from choosen period
* Unable to unlink a date_range with type fiscal_year
* `fiscal_year` flag readonly
* add menu to date_range under accounting section
* remove method on  object because it's the same as in  file
* unable to delete  with flag 'fiscal_year' but can delete
* clean __openerp__.py
* account_fiscal_year version number
@oca-transbot @bizzappdev
OCA Transbot updated translations from Transifex
5db8072
@espo-tony @bizzappdev
[10.0][MIGRATION] Migrated module 'account_fiscal_year' to V10 (OCA#407)
00854dd 
[MIG] Migrated module 'account_fiscal_year' to V10
@oca-transbot @bizzappdev
OCA Transbot updated translations from Transifex
99dd611
@TDu @bizzappdev
[MIG] account_fiscal_year: Migration to 11.
8b9b3e2
@oca-transbot @bizzappdev
OCA Transbot updated translations from Transifex
9b518e9 
[UPD] Update account_fiscal_year.pot
@osoul @bizzappdev
Added translation using Weblate (Arabic)
35c36dc
@oca-transbot @bizzappdev
OCA Transbot updated translations from Transifex
5f93c36
@hhgabelgaard @bizzappdev
Added translation using Weblate (Danish)
38ceb4f
@oca-travis @bizzappdev
[UPD] Update account_fiscal_year.pot
d1c5d75 
Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@OCA-git-bot @bizzappdev
[ADD] icon.png
886a985
@eLBati @bizzappdev
ADD refactored account_fiscal_year
d37eabf
@MiquelRForgeFlow @bizzappdev
[ADD] fiscalyear date.range.type data
b606879 
This date.range.type in v11 have benn used in some cases. Then, when you migrate, you need to have this data or else delete its xmlid.

We think it's better to keep it, because you may want to still use it.
@oca-travis @bizzappdev
[UPD] Update account_fiscal_year.pot
2288d97
@oca-transbot @bizzappdev
Update translation files
33d57a6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_fiscal_year
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_fiscal_year/
@OCA-git-bot @bizzappdev
[UPD] README.rst
8e2eb8f
@bizzappdev
Added translation using Weblate (Dutch)
6ea8dd3
@astirpe @bizzappdev
[13.0][MIG] account_fiscal_year
860cea2
@oca-travis @bizzappdev
[UPD] Update account_fiscal_year.pot
aaf9e20
@OCA-git-bot @bizzappdev
[UPD] README.rst
3191c49
@OCA-git-bot @bizzappdev
pre-commit update
5550481
@oca-transbot @bizzappdev
Update translation files
360695e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_fiscal_year
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_fiscal_year/
@SimoRubi @bizzappdev
[MIG] account_fiscal_year: Migration to 14.0
c481fd3
@SimoRubi @bizzappdev
account_fiscal_year: Date range dependency no more needed
b75a002
@oca-travis @bizzappdev
[UPD] Update account_fiscal_year.pot
ae62b34
@OCA-git-bot @bizzappdev
[UPD] README.rst
78d9657
@OCA-git-bot @bizzappdev
account_fiscal_year 14.0.1.0.1
896f74b
@alexis-via @bizzappdev
Add multi-company ir.rule on account.fiscal.year
b2c7cea
@HaraldPanten
Copy link
Contributor

/ocabot migration account_fiscal_year

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 17, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 17, 2024
Open
33 tasks
@salvorapi
Copy link

salvorapi commented Jun 3, 2024 •
edited
Loading

LGTM @fclementic2c

eLBati
eLBati suggested changes Jun 5, 2024
View reviewed changes
account_fiscal_year/__manifest__.py Outdated
"development_status": "Production/Stable",
"category": "Accounting",
"website": "https://github.com/OCA/account-financial-tools"
"14.0/account_fiscal_year",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

17.0 or https://github.com/OCA/account-financial-tools even better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to https://github.com/OCA/account-financial-tools only.

@peluko00
Copy link

peluko00 commented Jun 5, 2024

Can you push again for recreate build @bizzappdev please

@bizzappdev bizzappdev force-pushed the 17.0-mig-account_fiscal_year-BAD-SIP branch from 17ded32 to 72951b0 Compare June 5, 2024 14:42
@bizzappdev
Copy link
Contributor Author

@peluko00 Done and build also passed

peluko00
peluko00 approved these changes Jun 6, 2024
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@peluko00
Copy link

peluko00 commented Jun 6, 2024

@peluko00 Done and build also passed

Thanks!

mpascuall
mpascuall approved these changes Jun 6, 2024
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good, checked in runboat

eLBati
eLBati approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AaronHForgeFlow
AaronHForgeFlow approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Offtopic: This module was much better when it used to use date ranges 😢

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1834-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6453386 into OCA:17.0 Jul 17, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c8d6bd8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpascuall mpascuall mpascuall approved these changes

@peluko00 peluko00 peluko00 approved these changes

@yankinmax yankinmax yankinmax approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@salvorapi salvorapi salvorapi approved these changes

@vincent-hatakeyama vincent-hatakeyama vincent-hatakeyama approved these changes

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.