Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_asset_management: Set the default date from and date to for Financial Assets report wizard #1823

Merged

Conversation

DucTruongKomit
Copy link
Contributor

@DucTruongKomit DucTruongKomit commented Mar 1, 2024

Current Behavior:
When odoo only has 1 company and open Accounting -> Reporting -> Financial Assets -> Financial Assets Report.
Open the wizard, the Date from and Date to does not set as default.
image

Expected Behavior
When Odoo system only has 1 company, then Date From and Date To fields should be set default as current Company.

Note:
If there are multi company the date fields will be set as default as current month.

@AaronHForgeFlow
Copy link
Contributor

why not removing the groups attribute instead?

@DucTruongKomit
Copy link
Contributor Author

Hi thanks for your question!
I think we should not remove because for the case only 1 company(mostly happen I think), we don't need to display it.(selecting main_company by default)

If there are many company, user can select there choice.

@DucTruongKomit DucTruongKomit force-pushed the 16.0_account_asset_management_fix branch from 0cdfaa6 to 3e6a2d7 Compare December 6, 2024 10:36
@DucTruongKomit DucTruongKomit changed the title [16.0][FIX] - Set the default date from and date to [16.0][FIX] - Set the default date from and date to for Financial Assets report wizard Dec 6, 2024
@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 6, 2024
@pedrobaeza pedrobaeza changed the title [16.0][FIX] - Set the default date from and date to for Financial Assets report wizard [16.0][FIX] account_asset_management: Set the default date from and date to for Financial Assets report wizard Dec 6, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be considered as a bug in the migration to 16.

/ocabot merge patch

Please fw-port it to upper versions.

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1823-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c554f2f into OCA:16.0 Dec 6, 2024
11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f25fb39. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants