Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] account_move_update_analytic_account #1485

Conversation

remi-filament
Copy link
Contributor

Add new module allowing to update account analytic on posted moves
(Note that although model has changed, this is now allowed in v16)

@remi-filament remi-filament force-pushed the 14.0-add-account_move_update_analytic_account branch from 95da376 to 28a9e0c Compare November 3, 2022 15:10
@remi-filament remi-filament force-pushed the 14.0-add-account_move_update_analytic_account branch from 28a9e0c to fb54245 Compare November 10, 2022 08:14
@rafaelbn rafaelbn added this to the 14.0 milestone Nov 16, 2022
@rafaelbn
Copy link
Member

Hello @remi-filament , great! this could be really useful!

What about analytic tag? 😄

I should test this one!

@fclementic2c
Copy link
Member

Great idea this module. Thanks. I will test it.
I would suggest to use the branch : https://github.com/OCA/account-analytic instead. Don't you think ?

@fclementic2c
Copy link
Member

cannot test - Runbot could't start

@remi-filament
Copy link
Contributor Author

Hi @rafaelbn it should be quite straight forward if this module makes sense for other than us to add analytic tags in same wizard.
I give it a first try, but since we are not using these tags I was not sure if it made sense as well or not and it meant I had to manage access rights in wizard to apply changes or not (since for instance if you do not use analytic tags, the field would remain empty (since not diplayed), but does that mean that you have to empty the analytic tags for everyone or is it only because you do not see the field ?)

Let me know what you think about this first version and how it should work for analytic tags from your point of view and I should be able to implement those as well.

@remi-filament
Copy link
Contributor Author

cannot test - Runbot could't start

Maybe because there is an issue with pre-commit ? (I have not dug into it, but it seems to be related to GitHub actions with Python 11 since I see pre-commit failing everywhere now, while it was OK on my computer...)

@remi-filament
Copy link
Contributor Author

Great idea this module. Thanks. I will test it. I would suggest to use the branch : https://github.com/OCA/account-analytic instead. Don't you think ?

Yes makes sense, I should move it there !

@remi-filament
Copy link
Contributor Author

Closed as moved to account-analytic (OCA/account-analytic#497)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants