Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] account_asset_stock_move #1240

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[14.0][ADD] account_asset_stock_move #1240

merged 1 commit into from
Sep 19, 2023

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented Sep 23, 2021 •
edited
Loading

Normally, asset is created when vendor bill is confirmed (asset profile is set on invoice line)

But in case real time stock is used, stock move will create account moves, and it is possible to create asset on confirm of stock picking.

This should be useful for organization that want to create asset during stock in and not when confirm vendor bill.

  • Test

@kittiu kittiu force-pushed the 14.0-add-account_asset_stock_move branch 3 times, most recently from ec3e289 to c18c73a Compare September 29, 2021 09:25
@newtratip newtratip force-pushed the 14.0-add-account_asset_stock_move branch 3 times, most recently from 60d9f06 to 018292a Compare November 22, 2021 17:28
@newtratip
Copy link
Member

@kittiu, please check 018292a

@kittiu
Copy link
Member Author

kittiu commented Nov 23, 2021 •
edited
Loading

@kittiu, please check 018292a

I am ok

@ps-tubtim ps-tubtim force-pushed the 14.0-add-account_asset_stock_move branch from a2e4213 to 2cc34e4 Compare March 21, 2022 06:36
@ps-tubtim ps-tubtim force-pushed the 14.0-add-account_asset_stock_move branch 2 times, most recently from 926ebfd to 085574e Compare May 28, 2022 12:11
ps-tubtim
ps-tubtim approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@ps-tubtim ps-tubtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@marcelsavegnago
Copy link
Member

cc @douglascstd @augustodinizl

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tv-openbig
Copy link
Contributor

@kittiu Do you want to merge this PR ? I have reviewed the functionality locally and it is very useful.

Bildschirmfoto 2023-09-18 um 13 49 30

In the screenshot you can see that these assets was created from a stock move initiated by a manufacturing order (self produced asset).

@kittiu
Copy link
Member Author

kittiu commented Sep 19, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1240-by-kittiu-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 19, 2023
@OCA-git-bot
Merge PR #1240 into 14.0
503dfec 
Signed-off-by kittiu
@OCA-git-bot
Copy link
Contributor

@kittiu your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1240-by-kittiu-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@kittiu kittiu force-pushed the 14.0-add-account_asset_stock_move branch from 085574e to f60b5fe Compare September 19, 2023 02:27
@kittiu
Copy link
Member Author

kittiu commented Sep 19, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1240-by-kittiu-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 19, 2023
@OCA-git-bot
Merge PR #1240 into 14.0
db81f0d 
Signed-off-by kittiu
@kittiu kittiu force-pushed the 14.0-add-account_asset_stock_move branch from f60b5fe to 592219a Compare September 19, 2023 02:56
@kittiu
Copy link
Member Author

kittiu commented Sep 19, 2023

/ocabot merge nobump

1 similar comment
@kittiu
Copy link
Member Author

kittiu commented Sep 19, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

@kittiu your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1240-by-kittiu-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1240-by-kittiu-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 19, 2023
@OCA-git-bot
Merge PR #1240 into 14.0
67e5491 
Signed-off-by kittiu
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1240-by-kittiu-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 19, 2023
@OCA-git-bot
Merge PR #1240 into 14.0
906ecc4 
Signed-off-by kittiu
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1240-by-kittiu-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4a346aa into OCA:14.0 Sep 19, 2023
10 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0a01c92. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-tubtim ps-tubtim ps-tubtim approved these changes

@Saran440 Saran440 Saran440 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kittiu @newtratip @marcelsavegnago @OCA-git-bot @tv-openbig @Saran440 @ps-tubtim