Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] account_fiscal_year #1081

Merged
merged 26 commits into from
Jan 29, 2021
Merged

[14.0][MIG] account_fiscal_year #1081

merged 26 commits into from
Jan 29, 2021

Conversation

SimoRubi
Copy link
Member

@SimoRubi SimoRubi commented Nov 6, 2020

Migration extracting from v13 core, based on #1069 (comment)

damdam-s and others added 24 commits November 5, 2020 17:10
@damdam-s @SimoRubi
[ADD] add module "account_fiscal_year"
705ea3a
@lmignon @SimoRubi
[FIX] Tests
09b9db8
@damdam-s @SimoRubi
[FIX*IMP] account_fiscal_year
9c7b415 
* Add contributors to README
* try to find a FY start date according to the start date from choosen period
* Unable to unlink a date_range with type fiscal_year
* `fiscal_year` flag readonly
* add menu to date_range under accounting section
* remove method on  object because it's the same as in  file
* unable to delete  with flag 'fiscal_year' but can delete
* clean __openerp__.py
* account_fiscal_year version number
@oca-transbot @SimoRubi
OCA Transbot updated translations from Transifex
76de755
@espo-tony @SimoRubi
[10.0][MIGRATION] Migrated module 'account_fiscal_year' to V10 (OCA#407)
4814c92 
[MIG] Migrated module 'account_fiscal_year' to V10
@oca-transbot @SimoRubi
OCA Transbot updated translations from Transifex
bb671c8
@TDu @SimoRubi
[MIG] account_fiscal_year: Migration to 11.
01acd35
@oca-transbot @SimoRubi
OCA Transbot updated translations from Transifex
5421dcc 
[UPD] Update account_fiscal_year.pot
@osoul @SimoRubi
Added translation using Weblate (Arabic)
cb95046
@oca-transbot @SimoRubi
OCA Transbot updated translations from Transifex
cea7901
@hhgabelgaard @SimoRubi
Added translation using Weblate (Danish)
5da91c4
@oca-travis @SimoRubi
[UPD] Update account_fiscal_year.pot
016cdd5 
Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@OCA-git-bot @SimoRubi
[ADD] icon.png
337b98b
@eLBati @SimoRubi
ADD refactored account_fiscal_year
bca798b
@MiquelRForgeFlow @SimoRubi
[ADD] fiscalyear date.range.type data
745eb5f 
This date.range.type in v11 have benn used in some cases. Then, when you migrate, you need to have this data or else delete its xmlid.

We think it's better to keep it, because you may want to still use it.
@oca-travis @SimoRubi
[UPD] Update account_fiscal_year.pot
3c56933
@oca-transbot @SimoRubi
Update translation files
caa2639 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_fiscal_year
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_fiscal_year/
@OCA-git-bot @SimoRubi
[UPD] README.rst
2608a33
@SimoRubi
Added translation using Weblate (Dutch)
5be667d
@astirpe @SimoRubi
[13.0][MIG] account_fiscal_year
ba61054
@oca-travis @SimoRubi
[UPD] Update account_fiscal_year.pot
6222e54
@OCA-git-bot @SimoRubi
[UPD] README.rst
3971182
@OCA-git-bot @SimoRubi
pre-commit update
b7d3624
@oca-transbot @SimoRubi
Update translation files
0f3b16c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_fiscal_year
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_fiscal_year/
@OCA-git-bot
Copy link
Contributor

Hi @eLBati,
some modules you are maintaining are being modified, check this out!

@SimoRubi SimoRubi marked this pull request as ready for review November 6, 2020 12:04
@luc-demeyer
Copy link
Contributor

I don't think we need to have a depends on date_range for this module.

@SimoRubi
Copy link
Member Author

SimoRubi commented Nov 6, 2020

I don't think we need to have a depends on date_range for this module.

Thanks @luc-demeyer for having a look!
I checked and the date range type has been explicitly added by 9b4da88 and looks like there are some reasons to have it.
I'd keep it here because as for what concerns the migration, I'd try not to insert/remove any previous behavior.

I have just now remembered to update the README so I also mentioned it in there.

@luc-demeyer
Copy link
Contributor

@SimoRubi @MiquelRForgeFlow
I looked at 9b4da88 and still don't see a valid reason to keep the date_range dependency.
We may add a migration script to migrate the "fiscal_year" date_range objects to the account_fiscal_year objects but this can be done via post-migrate SQL script.

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, migration scripts are not needed. It's fine.

This was referenced Nov 10, 2020
Closed
Open
@jado95 jado95 mentioned this pull request Nov 13, 2020
Merged
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

tafaRU
tafaRU requested changes Nov 27, 2020
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking and questions, but looks good overall. Thanks a lot!

account_fiscal_year/__manifest__.py Show resolved Hide resolved
account_fiscal_year/models/res_company.py Outdated Show resolved Hide resolved
account_fiscal_year/models/res_company.py Show resolved Hide resolved
account_fiscal_year/tests/test_account_fiscal_year.py Show resolved Hide resolved
@AaronHForgeFlow
Copy link
Contributor

In this case, migration scripts are not needed. It's fine.

why? shouldn't we migrate from date_ranges to fiscal years?

@tafaRU
Copy link
Member

tafaRU commented Jan 22, 2021

@AaronHForgeFlow, are you ok with the merge even though #1081 (comment)?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU
Copy link
Member

tafaRU commented Jan 29, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1081-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b601250 into OCA:14.0 Jan 29, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b0f1d18. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jan 29, 2021
@alexis-via alexis-via mentioned this pull request Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati left review comments

@tafaRU tafaRU tafaRU approved these changes

@jado95 jado95 jado95 approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.