[16.0][ADD] account_move_line_profit_loss_balance #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norlinhenrik
force-pushed
the
16.0-add-account_move_line_pl
branch
2 times, most recently
from
1b84a03
to
1a80f3c
Compare
|
Hi @norlinhenrik prefer explicit module naming than implicit one. So, suffix should be profit_loss. |
norlinhenrik
force-pushed
the
16.0-add-account_move_line_pl
branch
5 times, most recently
from
4043e44
to
f308aa8
Compare
norlinhenrik
changed the title
norlinhenrik
force-pushed
the
16.0-add-account_move_line_pl
branch
from
f308aa8
to
a4658e1
Compare
|
Hi @rousseldenis Thank you for your feedback! I did some more improvements. Now you are welcome to review. |
norlinhenrik
force-pushed
the
16.0-add-account_move_line_pl
branch
from
a4658e1
to
803c88c
Compare
norlinhenrik
force-pushed
the
16.0-add-account_move_line_pl
branch
from
803c88c
to
fe0ca75
Compare
norlinhenrik
force-pushed
the
16.0-add-account_move_line_pl
branch
3 times, most recently
from
6de9af6
to
27d21a8
Compare
rvalyi
requested changes
Jul 28, 2024
There was a problem hiding this comment.
Hello @norlinhenrik thanks for contributing. It doesn't look bad, but could you please remove the mis_builder_cash_flow/static/description/index.html change from the commit?
(you can do a rebase -i, put the original index.html from the 16.0 branch, commit index.html with --amend) and do a push -f )
norlinhenrik
force-pushed
the
16.0-add-account_move_line_pl
branch
from
27d21a8
to
97eb685
Compare
|
Oops, how did that happen? I have removed the unwanted file now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module adds "Profit / Loss" and "Balance" to the reporting menu.
Some fields are added/modified in account.move.line: