[16.0][mig] partner_statement: Migration to 16.0 #1028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, if a payment was reconciled using the bank statement widget the move was seperated into many multiples of lines making activity statements twice as long as necessary. Now payments are a single line
By default we checked for an empty data dict in _get_report_values however the mail template sends a file type and editor key by default. We now check if the required company_id is in the dictionary. We also support supplying force_company in context for setting the company for auto generated emails. [UPD] README.rst [UPD] Update partner_statement.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/
In certain scenarios involving mutliple payments for multiple invoices, where the reconciliation happens together and the debit move is the smaller item the aging duplicates its value, making the balance greater than it should be. This fix works by preventing moves where different lines are both partial reconciled being grouped together by adding the lines id to the group by clause of _show_buckets_sql_q1
Currently translated at 100.0% (79 of 79 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/es/
Currently translated at 64.6% (51 of 79 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/fr/ [UPD] README.rst
Translated using Weblate (Portuguese (Brazil)) Currently translated at 17.7% (14 of 79 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/pt_BR/
Currently translated at 100.0% (79 of 79 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/pt_BR/
Currently translated at 100.0% (79 of 79 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/fr/
Currently translated at 86.1% (68 of 79 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/it/
…ash tests with other modules like as password_security
* Add files via upload Display only posted entries * Update activity_statement.py * Update report_statement_common.py [UPD] Update partner_statement.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/
[UPD] Update partner_statement.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-partner_statement/
Currently translated at 100.0% (77 of 77 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-partner_statement/es_AR/
Currently translated at 100.0% (77 of 77 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-partner_statement/es_AR/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-partner_statement/
Currently translated at 87.0% (67 of 77 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-partner_statement/it/
Currently translated at 72.7% (56 of 77 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-partner_statement/ro/
Currently translated at 90.9% (70 of 77 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-partner_statement/ro/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-14.0/account-financial-reporting-14.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-14-0/account-financial-reporting-14-0-partner_statement/
Currently translated at 100.0% (92 of 92 strings) Translation: account-financial-reporting-14.0/account-financial-reporting-14.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-14-0/account-financial-reporting-14-0-partner_statement/es_AR/
…ncy in Activity Statement By aggregating before the case statement there is no need to group by amount_currency. In earlier versions of Odoo this bug only presented in multicurrency transactions as company currency transactions would have an amount_currency of 0.0 and group by 0.0 just fine. In later versions of Odoo amount_currency is always set and this causes otherwise identical move lines that should be summed to display seperately. However, amount_currency was required in groupby because it was part of a non aggregated case statement with the sum inside. By reversing the nesting we remove the need to group by amount_currency. This is safe because we already group by currency_id and aggregates are not evaluated until after group by completes.
Currently translated at 70.6% (65 of 92 strings) Translation: account-financial-reporting-15.0/account-financial-reporting-15.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-15-0/account-financial-reporting-15-0-partner_statement/it/
Currently translated at 70.6% (65 of 92 strings) Translation: account-financial-reporting-15.0/account-financial-reporting-15.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-15-0/account-financial-reporting-15-0-partner_statement/it/
Currently translated at 71.7% (66 of 92 strings) Translation: account-financial-reporting-15.0/account-financial-reporting-15.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-15-0/account-financial-reporting-15-0-partner_statement/it/
Currently translated at 100.0% (92 of 92 strings) Translation: account-financial-reporting-15.0/account-financial-reporting-15.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-15-0/account-financial-reporting-15-0-partner_statement/pt/
7 tasks
|
Hi @dsolanki-initos , in upgrade from v14 to v16, there is error on table detailed.activity.statement.wizard because in this PR not exist, is correct? |
Yes, detailed.activity.statement.wizard was available in v14 but deprecated from v15. |
Ok Thanks, but at this point, don't we need an upgrade script or something to avoid the error? |
Maybe we do, maybe we don't. But if we do, it is not for a v16 PR, it is for V15. However all the info stated here is incorrect. detailed.activity.statement has not been deprecated. It is a recently added feature which is yet to be forward ported. Frankly it should be forward ported to this PR. I would also seriously consider basing this migration off v14 which is more mature than v15, or at the very least pulling in the unapproved PR's. |
|
@dsolanki-initos We have merged several commits in v15.0, could you rework this commit history to add them? |
|
Superseded here: #1071 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.