Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] analytic_partner: Migration to 17.0 #686

Merged
merged 20 commits into from
Sep 6, 2024

Conversation

BernatObrador
Copy link
Contributor

@BernatObrador BernatObrador commented Sep 5, 2024

pedrobaeza and others added 19 commits September 5, 2024 07:51
Classify analytic items by partner
==================================

This module adds a partner on each analytic item for allowing to have another
dimension for analysing data.

It also handles the proper propagation of this field to the created analytic
entries when validating invoices.

Configuration
=============

You have to be granted as at least "Accountant" in your user profile and
have checked the "Analytic Accounting" access right.

Usage
=====

Go to Accounting > Analytic Journal Items, and there, you can set the partner
for the analytic items, and search or group by it.

You can also go to a partner, and click on the smart-button "Cost/Revenue",
placed on the upper-right part, and you will navigate to the analytic items
associated to this partner.

Known issues / Roadmap
======================

* This module hasn't been tested with *account_analytic_plans* module
installed, so maybe it's incompatible with it.
* IMP: Distinguish between the partner of the account and the specific partner
* FIX: Allow grouping on partner_id field. Fixes OCA#41
* FIX: README - Indentation is not correct in Known issues.
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/gl/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/ca/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/pt_BR/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/zh_CN/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-16.0/account-analytic-16.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-analytic_partner/it/
@BernatObrador BernatObrador force-pushed the 17.0-mig-analytic_partner branch 4 times, most recently from a75e860 to 12a82ab Compare September 5, 2024 11:01
@BernatObrador BernatObrador force-pushed the 17.0-mig-analytic_partner branch from 8527a14 to 52fea42 Compare September 5, 2024 11:06
@BernatObrador
Copy link
Contributor Author

@pedrobaeza You know how to change active_id from here: https://github.com/OCA/account-analytic/pull/686/files#diff-f861e008ee81bfd994897fefa1fe928a7d19889d6dc187006a19dee44dbb6dab:~:text=%3Cfield%20name%3D%22domain%22%3E%5B(%27other_partner_id%27%2C%20%27child_of%27%2C%20active_id)%5D%3C/field%3E
When changing this to id odoo shows that error: EvalError: Can not evaluate python expression: ([('other_partner_id', 'child_of', id)])
Error: Name 'id' is not defined.
So maybe for now it's now a way to change active_id at the domain?

@pedrobaeza
Copy link
Member

But is there any warning using active_id? You should keep it if not.

@BernatObrador
Copy link
Contributor Author

@pedrobaeza thanks! It's not raising any warnings so, it's ok.

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

peluko00

This comment was marked as resolved.

Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration analytic_partner
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 6, 2024
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-686-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 69a1e14 into OCA:17.0 Sep 6, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 004fc05. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.