Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] mrp_stock_analytic #644

Merged
merged 10 commits into from
Oct 8, 2024
Merged

[17.0][MIG] mrp_stock_analytic #644

merged 10 commits into from
Oct 8, 2024

Conversation

aisopuro
Copy link
Contributor

@aisopuro aisopuro commented Apr 16, 2024 •
edited
Loading

Depends on

Notes

  • Includes an additional [IMP] commit since it wasn't strictly related to the migration. It can be squashed if the maintainers feel it is better that way

@aisopuro aisopuro force-pushed the 17.0-mig-mrp_stock_analytic branch from 348f636 to 6dc15b4 Compare April 16, 2024 08:38
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024
@aisopuro aisopuro force-pushed the 17.0-mig-mrp_stock_analytic branch 2 times, most recently from 50910de to a3cae24 Compare August 19, 2024 06:46
@aisopuro
Copy link
Contributor Author

Rebased on top of 17.0. @StefanRijnhart I think this is still active, are you able to mark it not stale?

@StefanRijnhart StefanRijnhart removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 19, 2024
@StefanRijnhart
Copy link
Member

@aisopuro We should be fine if we keep on being active on it! Can you check the failing tests?

@aisopuro
Copy link
Contributor Author

I took a look, but the trace suggests the failure is in stock_analytic, which is green in 17.0. So its probably some kind of non-trivial interaction, so I unfortunately probably won't manage to get to it anytime soon.

@StefanRijnhart
Copy link
Member

@aisopuro then this one will become stale again I'm afraid

@aisopuro aisopuro mentioned this pull request Aug 19, 2024
Merged
@aisopuro aisopuro force-pushed the 17.0-mig-mrp_stock_analytic branch from a3cae24 to 74853ac Compare August 19, 2024 08:00
@aisopuro aisopuro mentioned this pull request Sep 5, 2024
Open
@aisopuro aisopuro force-pushed the 17.0-mig-mrp_stock_analytic branch 3 times, most recently from da825f6 to 6ed3b79 Compare September 5, 2024 15:59
@aisopuro
Copy link
Contributor Author

aisopuro commented Sep 5, 2024

@StefanRijnhart I've fixed comments and rebased, this PR is good to go again.

@StefanRijnhart
Copy link
Member

@aisopuro Great work on the tests, thanks!

aisopuro added a commit to avoinsystems/account-analytic that referenced this pull request Sep 5, 2024
@aisopuro
[BETA] Merge in-progress PRs:
be8f71c 
* OCA#682
* OCA#644
* OCA#687
aisopuro added a commit to avoinsystems/account-analytic that referenced this pull request Sep 5, 2024
@aisopuro
[BETA] Merge additional commits from OCA#644
de13a73
@aisopuro aisopuro force-pushed the 17.0-mig-mrp_stock_analytic branch from d2f3771 to 67abad6 Compare September 6, 2024 05:38
StefanRijnhart
StefanRijnhart approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the follow-up!

@StefanRijnhart
Copy link
Member

@rousseldenis Is this one ok for you now?

@rousseldenis
Copy link
Contributor

@aisopuro Just improve commit message to make module name appears:

image

mymage and others added 7 commits October 7, 2024 14:44
@mymage @aisopuro
Added translation using Weblate (Italian)
6850d92
@mymage @aisopuro
Translated using Weblate (Italian)
00045c0 
Currently translated at 100.0% (4 of 4 strings)

Translation: account-analytic-16.0/account-analytic-16.0-mrp_stock_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-mrp_stock_analytic/it/
@aisopuro
[IMP] mrp_stock_analytic: pre-commit auto fixes
8482ee3
@aisopuro
[MIG] mrp_stock_analytic: Migration to 17.0
1992173 
* analytic_distribution is constrained to be valid on the MO, so we don't need to validate
  on confirmation
* The `states`-attribute on ORM-fields is deprecated, and should be moved to views
* mrp_account adds the distribution to the views we want, so we can just add attributes instead of re-adding the field
* mrp.production already has mixin.analytic, no need to re-add it
* analytic_distribution is already in the MO list view, no need to change its default visibility
@aisopuro
[IMP] mrp_stock_analytic: test backorder propagation
9ea467e
@aisopuro
[FIX] mrp_stock_analytic: Inheriting test class re-ran tests
d4ce5e2 
Switched to using shared base class instead
@aisopuro
[FIX] stock_analytic: tests fail if mrp also loads
0fc0a3e
@aisopuro aisopuro force-pushed the 17.0-mig-mrp_stock_analytic branch from 67abad6 to 0fc0a3e Compare October 7, 2024 11:47
@aisopuro
Copy link
Contributor Author

aisopuro commented Oct 7, 2024

Renamed and rebased @rousseldenis

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

/ocabot migration mrp_stock_analytic

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 8, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 8, 2024
Open
18 tasks
@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-644-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d442fb1 into OCA:17.0 Oct 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0495130. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostashiro yostashiro yostashiro left review comments

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@aisopuro @StefanRijnhart @rousseldenis @OCA-git-bot @yostashiro @mymage