[15.0][MIG] stock_analytic: migration #448

Mantux11 · 2022-04-12T11:25:15Z

Migration to 15.0. product file was deleted, because in original odoo 14 code _anglo_saxon_sale_move_lines function was deleted. I don't know why this was left in 14.0 migration, but I say that, if no one had problems, I don't see any issues that is associated with this, so I assume that this is not necessary to leave a file that don't do anything. Improved tests.

rousseldenis · 2022-05-17T09:29:18Z

@Mantux11 Can you review this in order to integrate it here too ?

#423

Thanks

AaronHForgeFlow

Functional LG! Pending to attend comments

Mantux11 · 2022-05-20T06:40:10Z

@rousseldenis I'm integrated. Migration script's I guess isn't needed because you do that in 14.0 version, so I don't add that. If it's needed, say, I would insert here also.

rousseldenis · 2022-05-20T06:52:17Z

@rousseldenis I'm integrated. Migration script's I guess isn't needed because you do that in 14.0 version, so I don't add that. If it's needed, say, I would insert here also.

Oops.

The good way is to cherry-pick it in order to keep authorship. Can you do it ?

And indeed, in your migration commit you can remove migration scripts.

Mantux11 · 2022-05-24T12:29:17Z

@rousseldenis I'll wait for your PR merge, because it would be easier for me to cherry pick.

Olageibol · 2022-06-08T15:13:49Z

In order to maintain the data security, I believe that the analytic_account_id field in stock.move.line views needs the analytic group added to it.
https://github.com/vialaurea/OCA-account-analytic/blob/15.0-mig-stock_analytic/stock_analytic/views/stock_move_line.xml

AaronHForgeFlow · 2022-09-28T16:26:07Z

can you include this? #423

Mantux11 · 2022-09-28T21:40:39Z

@AaronHForgeFlow yes, I would do that ASAP.

jlzhou · 2022-10-06T06:51:31Z

@Mantux11 thanks for your effort!

Could you please explain why remove _prepare_procurement_values override from stock.move model?

def _prepare_procurement_values(self): """ Allows to transmit analytic account from moves to new moves through procurement. """ res = super()._prepare_procurement_values() if self.analytic_account_id: res.update( { "analytic_account_id": self.analytic_account_id.id, } ) return res

oca-clabot · 2022-10-07T09:16:50Z

Hey @Mantux11, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

BT-cserra [email protected] (no github login found)
Hanane ELKHAL [email protected] (no github login found)
Hanane [email protected] (no github login found)
Cas Vissers [email protected] (no github login found)

Appreciation of efforts,
OCA CLAbot

… Stock analytic XML part is now migrated Add logo for generic modules

- migration point, put all the modules to not installable

This module allows the user to generate analytic information from stock moves. - Fixed flake8 and pylint errors.

Remove sale and purchase dependency. Add test Only assign analytic account if account != valuation acc Changing field name account_analytic_id Adjust to OCA latest guidelines. Add some usahe info on README

Remove remaining encoding hints. Correct lint in test Correct flake8 in test Fix documentation and test_flake8

Mantux11 · 2022-10-07T09:33:58Z

@AaronHForgeFlow I added all comitt's from 14. @jlzhou Returned this function,

AaronHForgeFlow

LG!

Mantux11 · 2022-11-28T11:29:11Z

@AaronHForgeFlow @jlzhou Could you Merge this PR? It's a valid migration, and it hasn't been reviewed for more than a month.

AaronHForgeFlow · 2022-11-28T11:41:31Z

@Mantux11 This needs an additional approval for the merge. Perhaps you can ping the people that have commented here but did not do a formal review.

rafaelbn · 2022-11-28T11:56:08Z

/ocabot migration stock_analytic

rafaelbn · 2022-11-28T11:57:40Z

I don't use this module. Ping my in 2 week if it not reviewed by other contributors. Thanks

Jerther

Missing coverage for one method. Otherwise, we've been using a previous version of this PR, identical but without this method, and we've been doing so for 2 or 3 months now and it's working fine. :)

stock_analytic/models/stock.py

florenciafrigieri2

Hi! I was trying to do a functional review in runboat and even though the analytic modules were installed, I was not able to allow analytic funcionalities even in the accounting app. Can you help me with that? Thanks in advance!

Mantux11 · 2022-11-30T09:58:16Z

@florenciafrigieri2 It's been a long time ago, when I tested this module, so personally, I forgot. If I will find, how and where, I will update this comment.

Jerther

100% code coverage, and working well. It's good to go!

OCA-git-bot · 2022-12-01T10:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

nicomacr

LGTM technical review

Mantux11 · 2022-12-21T09:59:04Z

@rafaelbn passed 2 weeks and PR has been approved. Could you review it and merge?

rousseldenis

Code review

@OCA/accounting-maintainers

grindtildeath · 2023-01-03T17:43:42Z

/ocabot merge nobump

OCA-git-bot · 2023-01-03T17:43:49Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-448-by-grindtildeath-bump-nobump, awaiting test results.

OCA-git-bot · 2023-01-03T17:51:41Z

Congratulations, your PR was merged at 1b17ae2. Thanks a lot for contributing to OCA. ❤️

Mantux11 mentioned this pull request Apr 12, 2022

Migration to version 15.0 #404

Closed

21 tasks

AaronHForgeFlow reviewed May 17, 2022

View reviewed changes

Mantux11 marked this pull request as draft October 7, 2022 09:19

Mantux11 closed this Oct 7, 2022

Hanane ELKHAL and others added 17 commits October 7, 2022 09:25

migration to v7

c1ceed4

merge with mathieu

1204786

update for migration V7

fb67fd8

add images

9a7a92f

update for wilog v7.0

342e568

Add contract customer invoice and migrate [IMP] SMS erase print [IMP]…

cbd0c2c

… Stock analytic XML part is now migrated Add logo for generic modules

- change the logo of all modules

c4b3c96

- migration point, put all the modules to not installable

- Added new module stock_analytic

ac6c921

This module allows the user to generate analytic information from stock moves. - Fixed flake8 and pylint errors.

Adapt original module according OCA Standard

a0b31bf

Remove sale and purchase dependency. Add test Only assign analytic account if account != valuation acc Changing field name account_analytic_id Adjust to OCA latest guidelines. Add some usahe info on README

OCA Transbot updated translations from Transifex

41cbbfe

[MIG]stock_analytic to v9

b263344

[MIG]stock_analytic to v10

a1ca73b

OCA Transbot updated translations from Transifex

d1243db

OCA Transbot updated translations from Transifex

371d820

OCA Transbot updated translations from Transifex

5b65a6c

11.0 MIG stock_analytic

eeda756

Add the ability to pick Analytic account on picking form.

0c76532

Remove remaining encoding hints. Correct lint in test Correct flake8 in test Fix documentation and test_flake8

Mantux11 reopened this Oct 7, 2022

Mantux11 marked this pull request as ready for review October 7, 2022 09:33

AaronHForgeFlow approved these changes Oct 8, 2022

View reviewed changes

rafaelbn added this to the 15.0 milestone Nov 28, 2022

rafaelbn added the needs review label Nov 28, 2022

Jerther suggested changes Nov 28, 2022

View reviewed changes

stock_analytic/models/stock.py Show resolved Hide resolved

florenciafrigieri2 reviewed Nov 28, 2022

View reviewed changes

Mantux11 requested a review from Jerther November 30, 2022 09:58

Jerther approved these changes Nov 30, 2022

View reviewed changes

OCA-git-bot added the approved label Nov 30, 2022

[15.0][MIG] stock_analytic: Migration

9f5fe3b

OCA-git-bot added the ready to merge label Dec 1, 2022

nicomacr approved these changes Dec 6, 2022

View reviewed changes

ps-tubtim mentioned this pull request Dec 22, 2022

[15.0][MIG] stock_request_analytic OCA/stock-logistics-warehouse#1587

Merged

1 task

rousseldenis approved these changes Dec 22, 2022

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jan 3, 2023

OCA-git-bot merged commit 27cd3a2 into OCA:15.0 Jan 3, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] stock_analytic: migration #448

[15.0][MIG] stock_analytic: migration #448

Mantux11 commented Apr 12, 2022

rousseldenis commented May 17, 2022

AaronHForgeFlow left a comment

Mantux11 commented May 20, 2022

rousseldenis commented May 20, 2022

Mantux11 commented May 24, 2022

Olageibol commented Jun 8, 2022

AaronHForgeFlow commented Sep 28, 2022

Mantux11 commented Sep 28, 2022

jlzhou commented Oct 6, 2022

oca-clabot commented Oct 7, 2022

Mantux11 commented Oct 7, 2022

AaronHForgeFlow left a comment

Mantux11 commented Nov 28, 2022

AaronHForgeFlow commented Nov 28, 2022

rafaelbn commented Nov 28, 2022

rafaelbn commented Nov 28, 2022

Jerther left a comment

florenciafrigieri2 left a comment

Mantux11 commented Nov 30, 2022

Jerther left a comment

OCA-git-bot commented Dec 1, 2022

nicomacr left a comment

Mantux11 commented Dec 21, 2022

rousseldenis left a comment

grindtildeath commented Jan 3, 2023

OCA-git-bot commented Jan 3, 2023

OCA-git-bot commented Jan 3, 2023

[15.0][MIG] stock_analytic: migration #448

[15.0][MIG] stock_analytic: migration #448

Conversation

Mantux11 commented Apr 12, 2022

rousseldenis commented May 17, 2022

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Mantux11 commented May 20, 2022

rousseldenis commented May 20, 2022

Mantux11 commented May 24, 2022

Olageibol commented Jun 8, 2022

AaronHForgeFlow commented Sep 28, 2022

Mantux11 commented Sep 28, 2022

jlzhou commented Oct 6, 2022

oca-clabot commented Oct 7, 2022

Mantux11 commented Oct 7, 2022

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Mantux11 commented Nov 28, 2022

AaronHForgeFlow commented Nov 28, 2022

rafaelbn commented Nov 28, 2022

rafaelbn commented Nov 28, 2022

Jerther left a comment

Choose a reason for hiding this comment

florenciafrigieri2 left a comment

Choose a reason for hiding this comment

Mantux11 commented Nov 30, 2022

Jerther left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Dec 1, 2022

nicomacr left a comment

Choose a reason for hiding this comment

Mantux11 commented Dec 21, 2022

rousseldenis left a comment

Choose a reason for hiding this comment

grindtildeath commented Jan 3, 2023

OCA-git-bot commented Jan 3, 2023

OCA-git-bot commented Jan 3, 2023