Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account_analytic_parent #434

Merged
merged 60 commits into from
Feb 8, 2022
Merged

[15.0][MIG] account_analytic_parent #434

merged 60 commits into from
Feb 8, 2022

Conversation

Dariosi
Copy link
Contributor

@Dariosi Dariosi commented Jan 28, 2022

No description provided.

AaronHForgeFlow and others added 30 commits January 28, 2022 11:54
@AaronHForgeFlow @Dariosi
account_analytic_parent
0a0a874
@cubells @Dariosi
[IMP] account_analytic_parent: add tree view to adviser wizard + Add …
0e14e22 
…demo data
@chienandalu @Dariosi
[MIG] account_analytic_parent: Migration to 10.0
e3e20e6
@oca-transbot @Dariosi
OCA Transbot updated translations from Transifex
19f84d4
@Dariosi
[MIG] account_analytic_parent: Migration to 11.0
44f2b9b 
* Removed groups attribute in tree xml element.

* Removed discarded hierarchical tree view support, plus wizard based on that functionality
@oca-travis @Dariosi
[UPD] Update account_analytic_parent.pot
09a7565
@rschnapka @Dariosi
Translated using Weblate (German)
cc28da6 
Currently translated at 100,0% (4 of 4 strings)

Translation: account-analytic-11.0/account-analytic-11.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-account_analytic_parent/de/
@Dariosi
Translated using Weblate (Catalan)
8baa725 
Currently translated at 100,0% (4 of 4 strings)

Translation: account-analytic-11.0/account-analytic-11.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-account_analytic_parent/ca/
@AaronHForgeFlow @Dariosi
[IMP] account_analytic_parent: performance (#200)
837fd9e
@AaronHForgeFlow @Dariosi
[IMP]propagate active through hierarchy
1fc5634
@oca-travis @Dariosi
[UPD] Update account_analytic_parent.pot
15ed7ef
@alexey-pelykh @Dariosi
[MIG] account_analytic_parent: Migration to 12.0
f46a911
@oca-travis @Dariosi
[UPD] Update account_analytic_parent.pot
685b4f0
@oca-transbot @Dariosi
Update translation files
bbe5d90 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@mvrodriguez @Dariosi
Translated using Weblate (Spanish)
5ff543b 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/es/
@mvrodriguez @Dariosi
Added translation using Weblate (Galician)
aede4bc
@mvrodriguez @Dariosi
Added translation using Weblate (Galician)
95ea7fa
@cubells @Dariosi
Fix compute credit debit and balance
94eb73c
@cubells @Dariosi
[IMP] account_analytic_parent: improve account tree view
7f851fd
@mvrodriguez @Dariosi
Translated using Weblate (Galician)
d30c3d0 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/gl/
@alexey-pelykh @Dariosi
[MIG] account_analytic_parent: improve account tree view
974d395
@pedrobaeza @Dariosi
[IMP] account_analytic_parent: Improvement on the read_group
1a755b7
@alexey-pelykh @Dariosi
[IMP] account_analytic_parent: Further improvement on read_group
c71f2e3
@alexey-pelykh @Dariosi
[FIX] account_analytic_parent: compute parent_path
0ce6800
@oca-travis @Dariosi
[UPD] Update account_analytic_parent.pot
1df82f5
@oca-transbot @Dariosi
Update translation files
56a475e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/
@Dariosi
Translated using Weblate (Dutch)
f19c8c8 
Currently translated at 54.5% (6 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/nl/
@badbole @Dariosi
Translated using Weblate (Croatian)
4b1b82b 
Currently translated at 100.0% (11 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/hr/
@BECJIE32 @Dariosi
Translated using Weblate (French)
0db7fd7 
Currently translated at 18.2% (2 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/fr/
@BECJIE32 @Dariosi
Translated using Weblate (Spanish)
1126813 
Currently translated at 90.9% (10 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/es/
@Dariosi Dariosi mentioned this pull request Jan 28, 2022
Closed
21 tasks
AaronHForgeFlow
AaronHForgeFlow reviewed Jan 29, 2022
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the balance should be positive in this example. Am I wrong?

image

@Dariosi
Copy link
Contributor Author

Dariosi commented Jan 31, 2022 •
edited
Loading

@AaronHForgeFlow
In this case balance of analytic account is calculated correctly.

Analytic accounts are about costs/expences (debit) and revenues/income (credit).
Negative balance means expences.

Module account_analytic_parent does not change the logic of balance calculation for analytic accounts.
The same balance logic is used in module analytic: https://github.com/odoo/odoo/blob/15.0/addons/analytic/models/analytic_account.py#L124

@AaronHForgeFlow
Copy link
Contributor

yes, sorry for the noise

AaronHForgeFlow
AaronHForgeFlow approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@AaronHForgeFlow
Copy link
Contributor

/ocabot migration account_analytic_parent

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 31, 2022
gaikaz
gaikaz approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@gaikaz gaikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@dreispt
Copy link
Member

dreispt commented Feb 6, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-434-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 6, 2022
@OCA-git-bot
Merge PR #434 into 15.0
f675ff1 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-434-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AaronHForgeFlow
Copy link
Contributor

Retrying the merge, it seems the build failed because of an infrastructure thing

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-434-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 288256d into OCA:15.0 Feb 8, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1e4dce1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mantux11 Mantux11 Mantux11 approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@gaikaz gaikaz gaikaz approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.