Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] purchase_analytic #424

Closed
wants to merge 19 commits into from
Closed

[14.0][MIG] purchase_analytic #424

wants to merge 19 commits into from

Conversation

AsierAcedo
Copy link

No description provided.

Laetitia Gangloff and others added 13 commits January 4, 2022 12:37
module to manage analytic on purchase order
d0fcef9
[10.0][MIG] port purchase_analytic to V10.0
b8111aa
@oca-travis
[UPD] Update purchase_analytic.pot
e026ed4
@OCA-git-bot
[ADD] icon.png
9cb5b8c
@MiquelRForgeFlow
[MIG] purchase_analytic: Migration to 12.0
5d8abb8
@oca-travis
[UPD] Update purchase_analytic.pot
55e9d37
@OCA-git-bot
[UPD] README.rst
8e28a0b
@oca-transbot
Update translation files
bc6e63c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-analytic-12.0/account-analytic-12.0-purchase_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-purchase_analytic/
@ps-tubtim
[IMP] purchase_analytic: black, isort
dddc635
@ps-tubtim
[MIG] purchase_analytic: Migration to 13.0
066cd59
@oca-travis
[UPD] Update purchase_analytic.pot
b5e585b
@eduardgm
Added translation using Weblate (Spanish)
094f02a
[IMP] purchase_analytic: black, isort, prettier
7ef803e
@AsierAcedo AsierAcedo mentioned this pull request Jan 4, 2022
Open
19 tasks
urtzi-coninpe
urtzi-coninpe approved these changes Jan 10, 2022
View reviewed changes
Copy link

@urtzi-coninpe urtzi-coninpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AaronHForgeFlow
AaronHForgeFlow reviewed Jan 29, 2022
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. Works perfectly.

The only thing is the migration commit. There is no migration commit, just the pre-commit commit. Can you fix that?

@AaronHForgeFlow
Copy link
Contributor

Hi @AsierAcedo those "merge" commits should not be there, it should be just one single commit for the migration. Can you check? Thanks in advance

@oca-clabot
Copy link

Hey @AsierAcedo,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

@AaronHForgeFlow
Copy link
Contributor

There are many commits for the migration. Maybe it is best to just retry the migration, you could just save your changes and then git reset --hard origin/14.0 and start the migration as usual: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0 WDYT?

@oca-clabot
Copy link

Hey @AsierAcedo,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

@rousseldenis
Copy link
Contributor

@AsierAcedo This is a duplicate of #402

Could you all review that one instead ?

@rousseldenis
Copy link
Contributor

@AaronHForgeFlow

@AaronHForgeFlow
Copy link
Contributor

I think we should go for the first PR created, that is green BTW

@AsierAcedo AsierAcedo deleted the 14.0-mig-purchase_analytic branch September 19, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow left review comments

@urtzi-coninpe urtzi-coninpe urtzi-coninpe approved these changes

@ajaniszewska-dev ajaniszewska-dev ajaniszewska-dev approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.