Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] Migration of procurement_mto_analytic #415

Merged
merged 17 commits into from
Feb 7, 2022

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Nov 29, 2021

Proposed changes

Migration PR for module procurement_mto_analytic.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation

@alan196 alan196 mentioned this pull request Nov 29, 2021
21 tasks
@alan196 alan196 force-pushed the 15.0-mig-procurement_mto_analytic branch from e88e034 to ef66c38 Compare November 29, 2021 23:13
Copy link

@ibraimFer ibraimFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete this migration

Copy link

@olveracuenca olveracuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10

Copy link

@MiguelJarsa MiguelJarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

Copy link

@MiguelJarsa MiguelJarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this migration looks good

Copy link

@marco1esparza marco1esparza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full migration to version 15.0

Copy link

@marco1esparza marco1esparza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete migration to version 15.0, good implementation

@rousseldenis
Copy link
Contributor

@alan196 Thanks for this

@marco1esparza Thanks not spamming the PR.

@dreispt
Copy link
Member

dreispt commented Feb 6, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-415-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 6, 2022
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-415-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AaronHForgeFlow
Copy link
Contributor

it failed because setupools when building the instance, let's try again:
/ocabot migration procurement_mto_analytic
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Feb 7, 2022
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-415-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d7ed83a into OCA:15.0 Feb 7, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 38710cd. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 15.0-mig-procurement_mto_analytic branch March 26, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.