Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] Migration of purchase_analytic #414

Merged
merged 14 commits into from
May 17, 2022

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Nov 29, 2021

Proposed changes

Migration PR for module purchase_analytic.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation

@alan196 alan196 mentioned this pull request Nov 29, 2021
21 tasks
@pedrobaeza
Copy link
Member

/ocabot migration purchase_analytic

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 30, 2021
Copy link

@JuanyDForgeflow JuanyDForgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@AaronHForgeFlow
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@AaronHForgeFlow The rebase process failed, because command git push --force Jarsa-dev tmp-pr-414:15.0-mig-purchase_analytic failed with output:

remote: Permission to Jarsa-dev/account-analytic.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/Jarsa-dev/account-analytic/': The requested URL returned error: 403

@rousseldenis
Copy link
Contributor

@alan196 Could you rebase ?

@alan196 alan196 force-pushed the 15.0-mig-purchase_analytic branch from 7e02920 to e35b997 Compare May 16, 2022 19:19
@alan196
Copy link
Contributor Author

alan196 commented May 16, 2022

@AaronHForgeFlow @rousseldenis Rebased 👍

@alan196
Copy link
Contributor Author

alan196 commented May 16, 2022

I also allowed @OCA-git-bot to write in Jarsa-dev repositories, who accepts the invitation to the bot?

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional + code, just a minor comment

purchase_analytic/readme/HISTORY.rst Show resolved Hide resolved
@alan196 alan196 force-pushed the 15.0-mig-purchase_analytic branch from e35b997 to c479570 Compare May 17, 2022 14:21
@AaronHForgeFlow
Copy link
Contributor

Yes, thanks

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-414-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4a8934a into OCA:15.0 May 17, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2d8aa95. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 15.0-mig-purchase_analytic branch May 17, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.