[14.0][MIG] product_analytic: Migration to 14.0

[Reyes4711-S73]

Standard migration to 14.0

[clementmbr]

In v14 this context is always false, leading to setting by default the product's income analytic account in all the new account.move.line. It seems better to use directly the account.move's move_type

Suggested change

	inv_type = self.env.context.get("inv_type", "out_invoice")
	inv_type = self.env["account.move"].browse([vals.get("move_id")]).move_type

[clementmbr]

Suggested change

	and inv_type
	and inv_type != "entry"

It looks better to avoid adding defautl analytic.account on new internal account.move.line...

[Reyes4711-S73]

Thank you for your review @clementmbr. I did your changes. Is possible you could review and approve this Pull request?

[billyang001]

In v14 ,An error occurred.
Odoo Server Error
Traceback (most recent call last):
File "/opt/odoo/src/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
result = request.dispatch()
File "/opt/odoo/src/odoo/http.py", line 683, in dispatch
result = self._call_function(**self.params)
File "/opt/odoo/src/odoo/http.py", line 359, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/opt/odoo/src/odoo/service/model.py", line 94, in wrapper
return f(dbname, *args, **kwargs)
File "/opt/odoo/src/odoo/http.py", line 347, in checked_call
result = self.endpoint(*a, **kw)
File "/opt/odoo/src/odoo/http.py", line 912, in call
return self.method(*args, **kw)
File "/opt/odoo/src/odoo/http.py", line 531, in response_wrap
response = f(*args, **kw)
File "/opt/odoo/src/addons/web/controllers/main.py", line 1389, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/opt/odoo/src/addons/web/controllers/main.py", line 1381, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/src/odoo/api.py", line 396, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/opt/odoo/src/odoo/api.py", line 383, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/opt/odoo/src/odoo/models.py", line 3009, in read
raise ValueError("Invalid field %r on model %r" % (name, self._name))
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/opt/odoo/src/odoo/http.py", line 639, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/opt/odoo/src/odoo/http.py", line 315, in _handle_exception
raise exception.with_traceback(None) from new_cause
ValueError: Invalid field 'hide_picking_type' on model 'stock.picking'

[Reyes4711-S73]

@billyang001 this field is added in the stock.picking model in the stock module from odoo. This module doesn't need this module to works correctly, so you must install stock module to solve your problem

[Du-ma]

LGTM

[rousseldenis]

@Reyes4711 Could you rebase ?

[rousseldenis]

@Reyes4711 @Du-ma I've done another PR based on this with some enhancments. If you can review and accept closing this one.