Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][FIX] stock_analytic: moves with different analytic accounts #288

Merged
merged 1 commit into from
Mar 24, 2020
Merged

[12.0][FIX] stock_analytic: moves with different analytic accounts #288

merged 1 commit into from
Mar 24, 2020

Conversation

Jerther
Copy link
Member

@Jerther Jerther commented Feb 7, 2020

Moves with different analytic accounts should not be merged.

This PR just adds analytic_account_id to the list of distinctive fields.

AaronHForgeFlow
AaronHForgeFlow approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-288-by-AaronHForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5202c85 into OCA:12.0 Mar 24, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9255622. Thanks a lot for contributing to OCA. ❤️

@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Mar 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-tubtim ps-tubtim ps-tubtim approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jerther @AaronHForgeFlow @OCA-git-bot @ps-tubtim