[10.0][ADD] Add default analytic account for accounts

[p-tombez]

Add the ability to set default analytic account on accounts.
This is useful when, e.g. you use the account_analytic_required
and have multi-currencies, thus need to create an automatic
currency exchange difference entry.

[simahawk]

skip it: this part is updated automatically ;)

[simahawk]

skip the 1st part. Just state "Go to Accounting..."

[simahawk]

can you rephrase this? The way I get is: "This account will be used by default for sale orders or invoices" or something similar :)

[simahawk]

I'd split this in more methods and simplify it a bit, for instance:

    account_get_domain_keys = (
        'product_id', 'partner_id', 'user_id',
        'date', 'company_id', 'account_id',
    )

    def _account_get_domain(self, **kw):
        """Build account.analytic.default domain.

        :param kw: filter keys.
            Available filter keys are defined into `account_get_domain_keys`.
        :return: a search domain with all required keys' leaves.
            Each key will be searched for both False and specified value.
            For instance: [
                ('product_id'), '=', False), '|', [('product_id'), '=', 100)
            ]
        """
        domain = []
        account_get_domain_keys = self.account_get_domain_keys[:]
        # date will be handled differently
        date_key = account_get_domain_keys.pop('date', None)

        for key in account_get_domain_keys:
            if kw.get(key):
                domain += ['|', (key, '=', kw.get(key))]
            domain += [(key, '=', False)]

        if date_key and kw.get(date_key):
            domain += ['|', ('date_start', '<=', kw.get(date_key)),
                       ('date_start', '=', False)]
            domain += ['|', ('date_stop', '>=', kw.get(date_key)),
                       ('date_stop', '=', False)]
        return domain

    def account_get(self, **kw):
        domain = self._account_get_domain(**kw)
        best_index = -1
        res = self.env['account.analytic.default']
        for rec in self.search(domain):
            index = 0
            for k in kw.keys():
                if rec[k]:
                    index += 1
            if index > best_index:
                res = rec
                best_index = index
        return res

[p-tombez]

I can't change the method signature so drastically as it already exists in the Odoo addons. I can't guarantee that the calls are made with kwargs everywhere. That's the main reason I copied the method and updated it for my needs.

[simahawk]

fine, you are right. Keep the signature as it is... but respect it in your calls if possible :)
Then you can still address the rest I guess ;)

[simahawk]

the method is supposed to accept keyword args

[simahawk]

same

[simahawk]

would you mind adding some tests for this?

[p-tombez]

@simahawk Thanks for the suggestions! I also added some tests

[simahawk]

???

[simahawk]

docstring explaining how you get to the right account

[simahawk]

don't use black magic. If the original method has some specific keys, use them.

[simahawk]

you don't need any wrapping:

@api.model
def account_get(self, product_id=None, partner_id=None, user_id=None,
                date=None, company_id=None, account_id=None):

    filters = {
        'product_id': product_id,
        'partner_id': partner_id,
        'user_id': user_id,
        'date': date,
        'company_id': company_id,
        'account_id': account_id,
    }
    domain = self._account_get_domain(**filters)
    keys = filters.keys()
    [...]

[simahawk]

you don't need this anymore as the keys are controlled by the main method signature

def _account_get_domain(self, **kw):
    """Build account.analytic.default domain.
    :param kw: filter keys.
        Available filter keys are defined into `account_get_domain_keys`.
    :return: a search domain with all required keys' leaves.
        Each key will be searched for both False and specified value.
        For instance: [
            ('product_id'), '=', False), '|', [('product_id'), '=', 100)
        ]
    """
    domain = []
    date_val = kw.pop('date', None)
    for key, value in kw.items():
        if value is not None:
            domain += ['|', (key, '=', value)]
        domain += [(key, '=', False)]

    if date_val:
        domain += ['|', ('date_start', '<=', date_val),
                   ('date_start', '=', False)]
        domain += ['|', ('date_stop', '>=', date_val),
                   ('date_stop', '=', False)]
    return domain

[simahawk]

remember to squash before merge

[fclementic2c]

cannot test it - runbot does not initate as normally :\

[feketemihai]

@pedrobaeza can you please metge this, i tested on tunbot as well..