[ENH] analytic_tag_dimension_enhanced: add exclude required module

analytic_tag_dimension/tests/test_analytic_dimension.py

@@ -4,12 +4,12 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from odoo.exceptions import ValidationError
-from odoo.tests.common import SavepointCase
+from odoo.tests.common import TransactionCase
 
 from ..hooks import uninstall_hook
 
 
-class TestAnalyticDimensionBase(SavepointCase):
+class TestAnalyticDimensionBase(TransactionCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()

analytic_tag_dimension_enhanced/models/account_analytic_dimension.py

@@ -28,6 +28,10 @@ class AccountAnalyticDimension(models.Model):
         default=False,
         help="If required, this dimension needed to be selected in working document",
     )
+    exclude_required = fields.Many2many(
+        comodel_name="ir.model",
+        string="Exclude Module Required",
+    )
     by_sequence = fields.Boolean(
         default=False,
         help="If checked, this dimemsion's tags will be available "

analytic_tag_dimension_enhanced/models/account_analytic_tag.py

@@ -36,6 +36,13 @@ def _check_required_dimension(self, record):
         tags_dimension = self.filtered("analytic_dimension_id.required")
         dimensions = tags_dimension.mapped("analytic_dimension_id")
         missing = req_dimensions - dimensions
+        # Check record in exclude required, it will skip it
+        if (
+            req_dimensions
+            and req_dimensions.exclude_required
+            and record._name in req_dimensions.exclude_required.mapped("model")
+        ):
+            missing = False
         if missing:
             raise ValidationError(
                 _("Following dimension(s) not selected: %s")

analytic_tag_dimension_enhanced/tests/test_analytic_dimension.py

@@ -41,6 +41,7 @@ def test_invoice_line_dimension_required(self):
         """
         self.dimension_1.required = True
         self.dimension_2.required = True
+        model = self.env["ir.model"].search([("model", "=", "account.move.line")])
 
         values = {
             "name": "test",
@@ -54,6 +55,12 @@ def test_invoice_line_dimension_required(self):
         # Error if missing required dimension
         with self.assertRaises(ValidationError):
             invoice_line_obj.create(values)
+
+        # Exclude required dimension (for some model)
+        self.dimension_1.exclude_required = model
+        line = invoice_line_obj.create(values)
+        self.assertTrue(line.x_dimension_test_dim_1.id == self.analytic_tag_1a.id)
+
         self.invoice.invoice_line_ids.unlink()
         values["analytic_tag_ids"] = [
             (6, 0, [self.analytic_tag_1a.id, self.analytic_tag_2a.id])

analytic_tag_dimension_enhanced/views/analytic_view.xml

@@ -11,6 +11,11 @@
             <field name="code" position="after">
                 <separator colspan="2" />
                 <field name="required" />
+                <field
+                    name="exclude_required"
+                    widget="many2many_tags"
+                    attrs="{'invisible': [('required', '=', False)]}"
+                />
                 <label for="by_sequence" />
                 <div>
                     <field name="by_sequence" class="oe_inline" />