[15.0][FIX] payment: Wait for payment methods to be created #4259
+32
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
changed the title
|
Please change the commit name to include the module name. |
pedrobaeza
reviewed
Dec 15, 2023
Since other modules create account.payment.method in this migration we need to wait for them before finding all payment methods and and connecting them to the journal and acquirer.
Meisolsson
force-pushed
the
15.0-fix-payment-method-journal-acquirer
branch
from
0051e8d to
d8e1f1c
Compare
|
My bad, I was sure I had cleaned up the old migration and I've must have missed the note about adding the module name. Should be fixed now. |
pedrobaeza
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since other modules create account.payment.method in this migration we need to wait for them before finding all payment methods and and connecting them to the journal and acquirer.
Discussed in #4257