Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][14.0] account_eid_proxy_client: nothing to do #3042

Merged
merged 1 commit into from
Jan 7, 2022
Merged

[MIG][14.0] account_eid_proxy_client: nothing to do #3042

merged 1 commit into from
Jan 7, 2022

Conversation

tranngocson1996
Copy link

This PR

Nothing to do

@tranngocson1996 tranngocson1996 changed the title [MIG] account_eid_proxy_client: nothing to do [MIG][14.0] account_eid_proxy_client: nothing to do Dec 31, 2021
@tranngocson1996
Copy link
Author

@legalsylvain I think this module nothing to do. What do you think?
cc: @pedrobaeza

legalsylvain
legalsylvain approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tranngocson1996
Copy link
Author

@pedrobaeza plz review !!!

@tranngocson1996
Copy link
Author

@pedrobaeza This simple module. Can you spare some time for it?

@pedrobaeza
Copy link
Member

Please don't ping me everywhere. Your contributions are welcome, but for now they are very asymmetric, only requiring to review, but not reviewing anything else. Take that into account and if this module is nothing to do, it's the same to be merged or not for doing the migrations, as the result is the same.

@tranngocson1996
Copy link
Author

Please don't ping me everywhere. Your contributions are welcome, but for now they are very asymmetric, only requiring to review, but not reviewing anything else. Take that into account and if this module is nothing to do, it's the same to be merged or not for doing the migrations, as the result is the same.

@pedrobaeza ok sir. I'm sr

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jan 7, 2022
@pedrobaeza pedrobaeza merged commit aff88dc into OCA:14.0 Jan 7, 2022
@pedrobaeza pedrobaeza mentioned this pull request Jan 7, 2022
Open
@tranngocson1996 tranngocson1996 mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain approved these changes

@pedrobaeza pedrobaeza Awaiting requested review from pedrobaeza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tranngocson1996 @pedrobaeza @legalsylvain