Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REM] remove migration script from net_weight to weight #2892

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

legalsylvain
Copy link
Contributor

the previous migration script was based on bad interpretation of the new unique weight field.

see OCA/product-attribute#894 for the whole discussion.

CC : @mbcosta, @pedrobaeza

@mbcosta
Copy link

mbcosta commented Aug 19, 2021

Hi @legalsylvain
I think should be better keep the script and just change the field, instead weight_net use weight.

@legalsylvain
Copy link
Contributor Author

hi @mbcosta not sure to understand.
In v8 : weight and weight_net
in V9 : weight

due to a bad documentation, I thought that the weight field in V9 was the old weight_net in V8, but if it's not the case, there is nothing to do in my opinion.
if not agree, could you explain which request to write ?

thanks !

@mbcosta
Copy link

mbcosta commented Aug 19, 2021

you right, good work

@pedrobaeza pedrobaeza merged commit 7003ff3 into OCA:9.0 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants