Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Add maintainers #2883

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Aug 4, 2021

Rational :

  • The ocabot has a new feature "Adopt a module", developped by @sbidoul. (Thanks to him !)
  • in OpenUgprade 14.0, script and framework are contained in odoo modules, for technical and visibility reasons

So, on each PR against Openupgrade, the "Adopt a module" will be displayed, that makes no sense.

Ref : #2882

Proposing so adding maintainers for both modules.

I proposed :

Feel free to update the list if you are not ok with that.

thanks !

@legalsylvain legalsylvain added this to the 14.0 milestone Aug 4, 2021
@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

@legalsylvain
Copy link
Contributor Author

@OCA-git-bot ... yes I know !

@MiquelRForgeFlow
Copy link
Contributor

The @OCA-git-bot comment has a typo, but I don't know how to edit it 🤔 @sbidoul

@legalsylvain
Copy link
Contributor Author

@sbidoul
Copy link
Member

sbidoul commented Aug 4, 2021

I can change but I don't see the typo.

@MiquelRForgeFlow
Copy link
Contributor

@sbidoul

(...) I take the opportunity to mention that you can you can consider adopting it. (...)

@sbidoul
Copy link
Member

sbidoul commented Aug 4, 2021

(...) I take the opportunity to mention that you can you can consider adopting it. (...)

Ahh... ok, thanks. Fixed and bot restarted.

@legalsylvain
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-2883-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eea5af5 into OCA:14.0 Aug 5, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fec263c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants