Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] event_crm #2855

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

MiquelRForgeFlow
Copy link
Contributor

Nothing to do.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Sep 15, 2021

I think these nothing-to-do PRs can be best merged manually without ocabot triggering another run from the github workflows, so I'll do just that, even if it feels a bit dirty.

@StefanRijnhart StefanRijnhart merged commit 29e61ff into OCA:14.0 Sep 15, 2021
@pedrobaeza pedrobaeza deleted the 14.0-mig-event_crm branch September 15, 2021 13:42
@pedrobaeza
Copy link
Member

But the dependency chain has been respected?

@StefanRijnhart
Copy link
Member

I would think yes, because otherwise, CI would not have been green on the PR.

@pedrobaeza
Copy link
Member

I see that both event and crm has been merged, but CI is not necessarily saying the truth, as if there are no migration scripts, but there's nothing that provokes an error, CI will be green.

@StefanRijnhart
Copy link
Member

OK. I did check for the 'blocked by dependency' label before merging but I'll do an extra check when merging manually next time.

@pedrobaeza
Copy link
Member

I think @MiquelRForgeFlow is very conscientious with the labels, so it can be OK if it has been removed. Sorry for the noise.

@StefanRijnhart
Copy link
Member

That's true, @MiquelRForgeFlow is very good with those labels!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants