Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] documentation: Prefix merged/renamed modules with Done #2797

Closed
wants to merge 1 commit into from

Conversation

pedrobaeza
Copy link
Member

So that the CI can detect them and check if there's something incorrect.

The paragraph about OCA modules has been removed as well, as that one is not maintained at all, and it's confusing then.

Let's see if this doesn't provoke a failed CI due to dependencies not yet "migrated".

@Tecnativa

So that the CI can detect them and check if there's something incorrect.

The paragraph about OCA modules has been removed as well, as that one is
not maintained at all, and it's confusing then.
@pedrobaeza pedrobaeza added this to the 14.0 milestone Jul 8, 2021
@pedrobaeza
Copy link
Member Author

As expected, this fails as it installs all the dependencies chain. We will have to progressively switch the comments according the evolution of the migration scripts. I keep this opened meanwhile as reminder.

@MiquelRForgeFlow
Copy link
Contributor

I don't like the deletion of the OCA modules section, as it might be used someday again. It was used to link an obsolete odoo module converted into OCA module.

@pedrobaeza
Copy link
Member Author

@MiquelRForgeFlow that's not true. See the account_bank_statement_import one for example, that is documented inline in the Odoo modules table. It was used marginally for OCA modules that were renamed, but nobody cares/maintains/checks this.

@StefanRijnhart
Copy link
Member

Are all of these covered by migration scripts if necessary?

If the OCA section is unused, it can go as far as I am concerned.

@StefanRijnhart
Copy link
Member

Can you rebase to see what the failed Github workflow does this time? Or trigger a rerun in some other way.

@MiquelRForgeFlow
Copy link
Contributor

We cannot merge it as it depends of other modules like account.

@StefanRijnhart
Copy link
Member

So that's the point, the modules should not be set to done unless they and all their dependencies are covered by migration scripts.

@MiquelRForgeFlow
Copy link
Contributor

Due to conflicts, rebased in #3523.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants