Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: schema test coverage #4173

Merged
merged 8 commits into from
Nov 21, 2024
Merged

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Nov 1, 2024

Thanks to @jdesrosiers we can now measure the coverage of our schema tests.

Bad news: it is pretty low right now:

  • 3.0: Covered: 258 of 531 (48%)
  • 3.1: Covered: 220 of 608 (36%)

Shamelessly copied from

@ralfhandl ralfhandl marked this pull request as draft November 6, 2024 14:52
@jeremyfiel
Copy link
Contributor

jeremyfiel commented Nov 11, 2024

I can help write some of these as I get time.. do you prefer a lot of smaller tests of individual items or combining many different ones into a large OAS file?

i have one available with up to 85+% coverage

@ralfhandl
Copy link
Contributor Author

For fail test cases I prefer minimalistic files that contain exactly one error.

For pass test cases "maximum" examples covering optional stuff in addition the required minimum are perfectly fine.

@ralfhandl ralfhandl marked this pull request as ready for review November 12, 2024 10:31
@ralfhandl ralfhandl changed the base branch from main to dev November 13, 2024 18:58
@ralfhandl ralfhandl changed the base branch from dev to main November 13, 2024 18:59
@handrews handrews merged commit 50103d8 into OAI:main Nov 21, 2024
2 checks passed
@ralfhandl ralfhandl deleted the main-schema-test-coverage branch November 21, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants